Bug #5075
closedPossibly misleading component value labels on Silkscreen
100%
Description
Some of the components have their value labeled next to them in the silkscreen. Unfortunately, this was done by placing loose text objects on the PCB, that aren't linked in any way to the component values in the schematic. Should they be removed? I wouldn't touch them, except that I have to re-arrange the silkscreen labels to increase the text size per https://osmocom.org/issues/5068
Files
Updated by cibomahto about 3 years ago
Note: The above screenshot only has a few of the labels highlighted, in fact all of the component values on the silkscreen are not with their schematic values.
Updated by mschramm about 3 years ago
Yes, this is a mess, - as there also 'real' errors like https://github.com/openvizsla/ov_ftdi/issues/42 . I'll discuss this with laforge , let's postpone this ticket towards the end and at least not before #5068.
Updated by laforge about 3 years ago
- Status changed from New to Feedback
- Assignee changed from laforge to mschramm
- removing all values (like 12Mhz, 120 Ohms) from the silk screen.
- keeping only the designators (R12, C55, ...) whihc hopefully are automatically generated
This reflects what we do in the "native, non-inherited" osmocom designs, too.
Furthermore:- [martin?] checking + [cibomahto] fixing all the labels next to pins/gpios, where we also know of at least one error (1V2 vs 5V)
Updated by mschramm about 3 years ago
- Status changed from Feedback to In Progress
- Assignee changed from mschramm to cibomahto
laforge wrote:
- removing all values (like 12Mhz, 120 Ohms) from the silk screen.
- keeping only the designators (R12, C55, ...) whihc hopefully are automatically generated
affirmative.
Me still searching for further errors on the pin header like the one known (see above).
Updated by cibomahto about 3 years ago
- File unassociated text strings - bottom.png unassociated text strings - bottom.png added
- File unassociated text strings - top.png unassociated text strings - top.png added
To aid in your search, here are snaps of all the text labels that are on the board, which are not linked to a component.
Updated by cibomahto about 3 years ago
Addressed here: https://github.com/openvizsla/ov_ftdi/pull/46/commits/c375a9521479726700d115124904ca306fbb89ec
- Remove component values from silkscreen
- Remove pin # labels and tick marks from silkscreen
- Verify that component designators are located next to the correct
parts - Fix 1v2 and 5v labels on P4
mschramm if you find any more errors, please let me know.
Updated by mschramm about 3 years ago
- File THT-deco-font.png THT-deco-font.png added
- % Done changed from 0 to 60
Thanks, looks good so far!
But somewhat even before the pin numbers on the THT headers went to ... erm, Arial ?! ;) Let them become calibri again (or a simple vector font).
Updated by cibomahto about 3 years ago
It looks like they were previously vector font, and got switched to the default truetype font (Arial). Updated here (and corrected the orientation of the ones on P3):
https://github.com/openvizsla/ov_ftdi/pull/46/commits/c6dcce2190937fdf3b5a1fd5100a4f517a3d7eca
These pin numbers do happen to be attached to the header footprints
Updated by cibomahto about 3 years ago
Updated by mschramm about 3 years ago
- File P3-deco-silk_bott.png P3-deco-silk_bott.png added
- % Done changed from 60 to 90
cibomahto wrote:
mschramm if you find any more errors, please let me know.
All THT header checked, only one error remaining:
Pin 19 of P3 is designated on the bottom side as TDI, which is wrong, it rather is connected to TDO. Please change this label on the bott side to TDO (lower case: "tdo").
Updated by cibomahto about 3 years ago
- File after.png after.png added
- File before.png before.png added
Updated by mschramm almost 3 years ago
- Status changed from In Progress to Resolved
- % Done changed from 90 to 100
solved, thanks