Actions
Bug #5136
closedNS2 claims to set DSCP but actually sets TOS bits
Start date:
04/27/2021
Due date:
% Done:
100%
Spec Reference:
Description
The NS2 code has code to set the dscp value based on vty settings.
However, it actually sets the TOS bit, of which DSCP are only the upper 6 bits.
So when we set the DSCP, we must- read the original TOS bit value
- mask out the upper 6 bits
- or-in the shifted DSCP value
- write it back to the kernel.
For RTP, we are getting it right as ortp is doing the shifting. But for ns2 we added a buggy implementation.
I'll add a generic helper function to libosmocore first and then use that from libosmogb/ns2
Related issues
Updated by laforge almost 3 years ago
- % Done changed from 0 to 80
Updated by laforge almost 3 years ago
- Related to Bug #5137: mgw claims to set DSCP but actually sets TOS bits added
Updated by laforge almost 3 years ago
- Status changed from In Progress to Resolved
- % Done changed from 80 to 100
Applied in changeset libosmocore|c96d716606b958f67c9cbcaa8f2e660042b233cc.
Actions