Actions
Bug #5251
closedVAMOS: CHANnel ACTIVation on shadow timeslots is broken
Start date:
10/09/2021
Due date:
% Done:
100%
Spec Reference:
Description
Starting from https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-bts-test/1432/, we see new regressions affecting all VAMOS related test cases. The problem is that osmo-bts started to NACK CHANnel ACTIVaction messages for lchans on the shadow timeslots:
(bts=0,trx=0,ts=1,shadow,pchan=TCH/F) rx chan activ but TS not in nm_state oper=ENABLED avail=OK, nack!
because they do not reflect the OML states of primary timeslots:
if (ts->mo.nm_state.operational != NM_OPSTATE_ENABLED ||
ts->mo.nm_state.availability != NM_AVSTATE_OK) {
LOGP(DRSL, LOGL_ERROR, "%s rx chan activ but TS not in nm_state oper=ENABLED avail=OK, nack!\n",
gsm_ts_and_pchan_name(ts));
return rsl_tx_chan_act_nack(lchan, RSL_ERR_RR_UNAVAIL);
}
and all members of ts->mo.nm_state are zero-initialized.
Updated by pespin over 2 years ago
So we need to get the primary TS then when checking that? Feel free to submit a patch then, you and neels worked on the vamos stuff and the shadow TS thing, so you probably know better.
Updated by pespin over 2 years ago
- Status changed from New to Feedback
- % Done changed from 0 to 90
Fixed by:
https://gerrit.osmocom.org/c/osmo-bts/+/25743 rsl: Fix all shadow TS being Chan Act NACKed
Updated by pespin over 2 years ago
- Status changed from Feedback to Resolved
- % Done changed from 90 to 100
This should be fixed now that the patch was merged, closing the ticket.
Actions