Project

General

Profile

Actions

Bug #5301

open

Run TTCN3 docker tests with sanitizer enabled

Added by daniel 28 days ago. Updated 23 days ago.

Status:
New
Priority:
Normal
Assignee:
Target version:
-
Start date:
11/10/2021
Due date:
% Done:

0%

Spec Reference:

Description

After updating libosmocore I noticed that the TTCN3 GbProxy tests start to fail with an ASan issue when run locally.

I think at least for the TTCN3 tests on master we should enable San to catch hidden bugs early. Unfortunately this has a large impact on how the osmo--master docker images are built if we want to enable it for the libraries as well - currently we install the nightly packages and build the target from master.

Instead we could build an image that builds all the libraries from master (with sanitizer enabled) and installs those and then use that as base for osmo-*-master.

Not sure what the downsides are, any ideas?


Related issues

Related to libosmocore - Bug #5302: ns2: ASan heap-use-after-free in ns2_nse_notify_unblocked() when running GBProxy_Tests.TC_bvc_reset_blocked_ptp_from_sgsnResolveddaniel11/10/2021

Actions
Actions #1

Updated by daniel 27 days ago

  • Related to Bug #5302: ns2: ASan heap-use-after-free in ns2_nse_notify_unblocked() when running GBProxy_Tests.TC_bvc_reset_blocked_ptp_from_sgsn added
Actions #2

Updated by osmith 26 days ago

Instead we could build an image that builds all the libraries from master (with sanitizer enabled) and installs those and then use that as base for osmo-*-master.

If we do that instead of the current debian and centos tests, then we end up not testing the distro packages anymore. But this was the point, and the reason why we test both debian and centos as I understand.

How about we do what you described, but in addition to the tests that make use of distro packages?

We could have a new TTCN3-san view, next to:

If we only test master and not latest too, then this new view has only half as much jobs.

laforge, what do you think?

Actions #3

Updated by laforge 25 days ago

On Fri, Nov 12, 2021 at 03:36:30PM +0000, wrote:

Instead we could build an image that builds all the libraries from master (with sanitizer enabled) and installs those and then use that as base for osmo-*-master.

If we do that instead of the current debian and centos tests, then we end up not testing the distro packages anymore. But this was the point, and the reason why we test both debian and centos as I understand.

ACK.

How about we do what you described, but in addition to the tests that make use of distro packages?

We could have a new TTCN3-san view, next to:

If we only test master and not latest too, then this new view has only half as much jobs.

OK. I would argue to test master once per day only, and not every commit. I can add more
build slaves if we run into problems there.

Actions #4

Updated by daniel 23 days ago

laforge wrote in #note-3:

On Fri, Nov 12, 2021 at 03:36:30PM +0000, wrote:

How about we do what you described, but in addition to the tests that make use of distro packages?

We could have a new TTCN3-san view, next to:

If we only test master and not latest too, then this new view has only half as much jobs.

OK. I would argue to test master once per day only, and not every commit. I can add more
build slaves if we run into problems there.

Yeah, that would be great. I think TTCN3 tests every commit is a bit too much anyway (with or without sanitizer). Running it once per day is fine.

Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)