Project

General

Profile

Actions

Bug #5368

open

consider using SCTP_EVENT instead of SCTP_EVENTS

Added by laforge about 2 years ago. Updated about 2 years ago.

Status:
Feedback
Priority:
Low
Assignee:
-
Target version:
-
Start date:
12/22/2021
Due date:
% Done:

0%

Spec Reference:

Description

The infamous SCTP_EVENTS and its ABI breakage (#4573) have been deprecated by IETF in 2011 already, and a new SCTP_EVENT option has been introduced. See https://datatracker.ietf.org/doc/html/rfc6458 Section 6.2.2.

We could switch libosmo-netif over to the new socket option.

However, Linux only introduced support for SCTP_EVENT in 2018 in

commit 480ba9c18a27ff77b02a2012e50dfd3e20ee9f7a
Author: Xin Long <lucien.xin@gmail.com>
Date:   Sun Nov 18 16:08:54 2018 +0800

    sctp: add sockopt SCTP_EVENT

    This patch adds sockopt SCTP_EVENT described in rfc6525#section-6.2.
    With this sockopt users can subscribe to an event from a specified
    asoc.

    Signed-off-by: Xin Long <lucien.xin@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>

The related code is hence only present in kernels >= 5.0

So it seems like a better choice to stay with SCTP_EVENTS for now as we need it to support older kernels anyway.


Related issues

Related to Cellular Network Infrastructure - Bug #4573: [centos] ttcn3-msc-test: 177 failures!Resolvedlaforge06/01/2020

Actions
Related to Cellular Network Infrastructure - Bug #5366: ttcn3-{bsc,msc,sgsn,smlc,sccp}-test regressions due to timeout waiting for RESET-ACKResolveddaniel12/21/2021

Actions
Actions #1

Updated by laforge about 2 years ago

  • Related to Bug #4573: [centos] ttcn3-msc-test: 177 failures! added
Actions #2

Updated by laforge about 2 years ago

  • Related to Bug #5366: ttcn3-{bsc,msc,sgsn,smlc,sccp}-test regressions due to timeout waiting for RESET-ACK added
Actions #3

Updated by fixeria about 2 years ago

  • Status changed from New to Feedback

The related code is hence only present in kernels >= 5.0

So it seems like a better choice to stay with SCTP_EVENTS for now as we need it to support older kernels anyway.

We can implement run-time probing for SCTP_EVENT and fallback to SCTP_EVENTS if setsockopt() fails.

Here is my untested WIP patch: https://git.osmocom.org/libosmo-netif/commit/?h=fixeria/sctp_event&id=61ed7fcd7ae90ac024d421efc5237adb69c080fd

Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)