Project

General

Profile

Actions

Feature #5407

closed

jenkins job to build osmocom/dahdi-linux against torvalds/linux.git

Added by laforge about 2 years ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
DAHDI driver
Target version:
-
Start date:
01/20/2022
Due date:
% Done:

100%

Spec Reference:

Description

Let's have a daily build of https://git.osmocom.org/dahdi-linux/ against https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/ in ordert to catch any incompatibility with upstream as soon as it occurs.


Checklist

  • jenkins build against torvalds/linux.git
  • jenkins build against 4.19 (gerrit)
  • jenkins build against 5.10 (gerrit)
  • set up gerrit
  • fix build against linux master
  • enable master-dahdi-linux-* jenkins jobs

Related issues

Related to E1/T1 Hardware Interface (including icE1usb) - Bug #5408: linux 5.16: #include stdbool.h required in DAHDIResolvedlaforge01/20/2022

Actions
Actions #1

Updated by laforge about 2 years ago

  • Related to Bug #5408: linux 5.16: #include stdbool.h required in DAHDI added
Actions #2

Updated by laforge about 2 years ago

  • Checklist item jenkins build against torvalds/linux.git added
  • Checklist item jenkins build against 4.19 added
  • Checklist item jenkisn build against 5.10 added

current master will fail due to #5408 which will need to be fixed.

In fact, now that I think about it, we should actaully build against multiple kernel versions to ensure we don't break backwards compatibility with new changes.

I think we should use at least the kernel version usd by debian 11 (5.10) and debian 10 (4.19) as base-line

I guess if the jekins-job template is created the right way, creating more jobs for other kernel git trees/tags should be rather easy.

Actions #3

Updated by laforge about 2 years ago

  • Checklist item changed from jenkisn build against 5.10 to jenkins build against 5.10
we might actually also consider setting up gerrit for dahdi-linux, and then have the following split:
  • verify against 4.19, 5.10 and possibly more kernels in gerrit for every new patch
  • verify nightly against the [moving] torvalds/linux.git
Actions #4

Updated by laforge about 2 years ago

  • Checklist item set up gerrit added

I've set up gerrit, see https://gerrit.osmocom.org/q/project:dahdi-linux - please take over the jenkins jobs.

Actions #5

Updated by osmith about 2 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 20
Actions #6

Updated by osmith about 2 years ago

  • Checklist item changed from jenkins build against 4.19 to jenkins build against 4.19 (gerrit)
  • Checklist item changed from jenkins build against 5.10 to jenkins build against 5.10 (gerrit)
  • Checklist item jenkins build against 4.19 (gerrit) set to Done
  • Checklist item jenkins build against 5.10 (gerrit) set to Done
  • % Done changed from 20 to 70

laforge wrote in #note-3:

we might actually also consider setting up gerrit for dahdi-linux, and then have the following split:
  • verify against 4.19, 5.10 and possibly more kernels in gerrit for every new patch

Implemented here: https://gerrit.osmocom.org/q/topic:dahdi-ci

Adding new kernels is as easy now as adding one line to the jenkins job yml and updating the job.

  • verify nightly against the [moving] torvalds/linux.git

I'll do that next. When I tried to build against linux master yesterday, it failed FWIW. So we might not want to enable this as nightly build before it's known to be passing initially?

I guess it would make sense to build master against 4.19 and 5.10 as well, similar to the master-osmo-* jobs we already have?

Actions #7

Updated by osmith about 2 years ago

  • Checklist item fix build against linux master added
  • Checklist item enable master-dahdi-linux-* jenkins jobs added
  • Checklist item jenkins build against torvalds/linux.git set to Done

Added jenkins jobs to build dahdi-linux master against linux 4.19, 5.10 and master. But disabled the job for now, as it would fail until contrib/jenkins.sh is merged, and as it will fail against linux master.

Actions #8

Updated by laforge about 2 years ago

osmith wrote in #note-6:

laforge wrote in #note-3:

we might actually also consider setting up gerrit for dahdi-linux, and then have the following split:
  • verify against 4.19, 5.10 and possibly more kernels in gerrit for every new patch

Implemented here: https://gerrit.osmocom.org/q/topic:dahdi-ci

Adding new kernels is as easy now as adding one line to the jenkins job yml and updating the job.

  • verify nightly against the [moving] torvalds/linux.git

I'll do that next. When I tried to build against linux master yesterday, it failed FWIW. So we might not want to enable this as nightly build before it's known to be passing initially?

I've started the job now once to see what is breaking, planning to fix it then.

I guess it would make sense to build master against 4.19 and 5.10 as well, similar to the master-osmo-* jobs we already have?

yes, thanks.

Actions #9

Updated by laforge almost 2 years ago

  • Checklist item fix build against linux master set to Done
  • Checklist item enable master-dahdi-linux-* jenkins jobs set to Done
  • % Done changed from 70 to 90

I've now fixed the build against master in https://jenkins.osmocom.org/jenkins/job/master-dahdi-linux-master/6/ and re-activated the mater-dahdi-linux-master job.

What I don't understand is why the latter job is using -Werror while normally the kernel nor dahdi are built that way. Also, our 4.19 and 5.10 builds do not use -Werror. Let's please disable this unintende dbehavior.

Actions #10

Updated by osmith almost 2 years ago

laforge wrote in #note-9:

What I don't understand is why the latter job is using -Werror while normally the kernel nor dahdi are built that way. Also, our 4.19 and 5.10 builds do not use -Werror. Let's please disable this unintende dbehavior.

It's default since Linux 5.15:
https://www.phoronix.com/scan.php?page=news_item&px=Linux-5.15-Werror

This patch disables -Werror:
https://gerrit.osmocom.org/c/dahdi-linux/+/27917

Actions #11

Updated by osmith over 1 year ago

  • Status changed from In Progress to Resolved
  • % Done changed from 90 to 100

all patches are merged, and we decided to not disable werror.

Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)