Cellular Network Infrastructure » Radio Access Network » OsmoTRX

master-libusrp is failing since building in debian 10 instead of 9 (#5601). I have a fix ready, but creating this issue to point to in the patch.

Error message, e.g. from https://jenkins.osmocom.org/jenkins/job/master-libusrp/a1=default,a2=default,a3=default,a4=default,label=osmocom-master-debian9/1669/console:

make[3]: Entering directory '/build/libusrp-3.4.6/_build/sub/host/lib'
 /bin/bash ../../libtool   --mode=uninstall rm -f '/build/libusrp-3.4.6/_inst/lib/libusrp.la'
libtool: uninstall: rm -f /build/libusrp-3.4.6/_inst/lib/libusrp.la /build/libusrp-3.4.6/_inst/lib/libusrp.so.1.0.0 /build/libusrp-3.4.6/_inst/lib/libusrp.so.1 /build/libusrp-3.4.6/_inst/lib/libusrp.so
/bin/bash: -c: line 11: syntax error near unexpected token `|'
/bin/bash: -c: line 11: `echo "$py_files" |  | sed '$!N;$!N;$!N;$!N;$!N;$!N;$!N;s/\n/ /g' | sed '$!N;$!N;$!N;$!N;s/\n/ /g' | \'
make[3]: *** [Makefile:936: uninstall-usrppythonPYTHON] Error 1

After running ./configure, host/lib/Makefile.in contains:

uninstall-usrppythonPYTHON:
    @$(NORMAL_UNINSTALL)
    @list='$(usrppython_PYTHON)'; test -n "$(usrppythondir)" || list=; \
    py_files=`for p in $$list; do echo $$p; done | sed -e 's|^.*/||'`; \
    test -n "$$py_files" || exit 0; \
    dir='$(DESTDIR)$(usrppythondir)'; \
    pyc_files=`echo "$$py_files" | sed 's|$$|c|'`; \
    pyo_files=`echo "$$py_files" | sed 's|$$|o|'`; \
    st=0; \
    for files in "$$py_files" "$$pyc_files" "$$pyo_files"; do \
      $(am__uninstall_files_from_dir) || st=$$?; \
    done; \
    dir='$(DESTDIR)$(usrppythondir)'; \
    echo "$$py_files" | $(am__pep3147_tweak) | $(am__base_list) | \
      while read files; do \
        $(am__uninstall_files_from_dir) || st=$$?; \
      done || exit $$?; \
    exit $$st

This is the relevant line:

    echo "$$py_files" | $(am__pep3147_tweak) | $(am__base_list) | \

Apparently am__pep3147_tweak is empty, and so the syntax error occurs.

I found a bug report here: https://bugzilla.redhat.com/show_bug.cgi?id=1716384#c0

This also links to an upstream patch in autotools that according to the redhat bug report should solve the issue, but from the upstream patch commit message it's not clear to me if it really applies to this bug. In the interest of not spending too much time on this, I'll patch the Makefile to skip the uninstall for python files, this package only uses python scripts to generate sources but doesn't actually install the python scripts. So the uninstall should be a no-op anyway.