Project

General

Profile

Actions

Bug #5655

closed

Fix packaging

Added by osmith over 1 year ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
Start date:
08/22/2022
Due date:
% Done:

100%

Spec Reference:

Description

The debian and rpm packages do not build. After fixing obvious missing dependency errors, the following errors remain:

Debian 11:
https://obs.osmocom.org/package/live_build_log/home:osmith:nightly/osmo-upf/Debian_11/x86_64

[  151s] libtool: link: gcc -Wall -pthread -I/usr/include/ -pthread -I/usr/include/ -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-z -Wl,relro -o osmo-upf osmo_upf_main.o up_endpoint.o up_gtp_action.o up_peer.o up_session.o upf.o upf_gtp.o upf_gtpu_echo.o upf_nft.o upf_vty.o  /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so /usr/lib/x86_64-linux-gnu/libosmocore.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmo-gtlv.so /usr/lib/x86_64-linux-gnu/libosmo-pfcp.so /usr/lib/x86_64-linux-gnu/libgtpnl.so -lnftnl -lnftables -pthread
[  151s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libosmo-pfcp.so: undefined reference to `osmo_gtlvs_decode'
[  151s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libosmo-pfcp.so: undefined reference to `osmo_gtlvs_encode'
[  151s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libosmo-pfcp.so: undefined reference to `osmo_t16l16v_cfg'
[  151s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libosmo-pfcp.so: undefined reference to `osmo_gtlvs_encode_to_str_buf'

CentOS 8:
https://obs.osmocom.org/package/live_build_log/home:osmith:nightly/osmo-upf/CentOS_8/x86_64

[   37s] + export LICENSEDIR
[   37s] + /usr/bin/mkdir -p /home/abuild/rpmbuild/BUILDROOT/osmo-upf-0.1.0-7.1.x86_64/usr/share/licenses/osmo-upf
[   37s] + cp -pr COPYING /home/abuild/rpmbuild/BUILDROOT/osmo-upf-0.1.0-7.1.x86_64/usr/share/licenses/osmo-upf
[   37s] cp: cannot stat 'COPYING': No such file or directory
[   37s] + :
[   37s] + exit 0
[   37s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/osmo-upf-0.1.0-7.1.x86_64/usr/share/licenses/osmo-upf/COPYING
[   37s] 
[   37s] 
[   37s] RPM build errors:
[   37s]     File not found: /home/abuild/rpmbuild/BUILDROOT/osmo-upf-0.1.0-7.1.x86_64/usr/share/licenses/osmo-upf/COPYING

I guess it should be AGPL-3.0-or-later? The COPYING file is missing obviously, and in SPDX headers it says GPL-2.0+.

openSUSE 15.4:
https://obs.osmocom.org/package/live_build_log/home:osmith:nightly/osmo-upf/15.4/x86_64

[   27s] Making all in osmo-pfcp-tool
[   27s] make[3]: Entering directory '/home/abuild/rpmbuild/BUILD/osmo-upf/src/osmo-pfcp-tool'
[   27s]   CC       osmo_pfcp_tool_main.o
[   27s]   CC       pfcp_tool_vty.o
[   27s]   CC       pfcp_tool.o
[   28s] osmo_pfcp_tool_main.c:219:15: error: initializer element is not constant
[   28s]   .copyright = osmo_pfcp_tool_copyright,
[   28s]                ^~~~~~~~~~~~~~~~~~~~~~~~
[   28s] osmo_pfcp_tool_main.c:219:15: note: (near initialization for 'pfcp_tool_vty_app_info.copyright')
[   28s] make[3]: *** [Makefile:461: osmo_pfcp_tool_main.o] Error 1

osmo-upf also introduces a dependency to latest versions of libnftables and libnftnl. I have added these to the Osmocom nightly repository.

I'll create a patch to stop generating nightly source packages for osmo-upf, so we don't generate lots of e-mails about the build failures anymore before this is fixed.


Related issues

Related to Cellular Network Infrastructure - Bug #5654: OBS errors for libosmo-pfcp, osmo-upf, osmo-hnbgwResolvedosmith08/22/2022

Actions
Actions #1

Updated by osmith over 1 year ago

The following patch fixes the obvious missing libnftnl, libnftables dependencies. I applied it before getting the errors above.

https://gerrit.osmocom.org/c/osmo-upf/+/29188

Actions #2

Updated by osmith over 1 year ago

  • Related to Bug #5654: OBS errors for libosmo-pfcp, osmo-upf, osmo-hnbgw added
Actions #4

Updated by osmith over 1 year ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)