Miscellaneous Projects » Core testing infrastructure

osmo-ttcn3-hacks/ttcn3-dumpcap-start.sh and osmo-ttcn3-hacks/ttcn3-tcpdump-start.sh both contain variable resolutions without quotes inside shell-test statements, here is an example from the latter:

if [ -x $DUMPCAP ]; then

If the variable is empty, the shell (also tried this with dash) will evaluate the test statement as true and we get misleading error logs in the latter case. Either way, it's most likely not what was intended. Putting quotes around the expression for variable resolution (i.e. putting "$DUMPCAP" instead) fixes this.