Feature #5785
closedenable either TCP or IPA keep-alive by default
100%
Description
If I read our code correctly, neither TCP nor IPA keep-alives are activated by default on Abis RSL/OML. (see code review in #5106).
Let's validate this. If that is true, I think at least either of the two should be enabled by default. My preference would be the TCP keepalive code, as it's more intelligent (don't send keepalives as long as there's traffic) and also covers situations not directly visible to the application (window stalled).
Related issues
Updated by laforge over 1 year ago
- Related to Feature #5106: Watchdog that would try to un-BORKE BORKen timeslots added
Updated by osmith over 1 year ago
- Status changed from New to Feedback
- Assignee changed from osmith to laforge
- % Done changed from 0 to 90
Yes, both ipa and tcp keepalive were not enabled by default.
This patch enables tcp keepalive by default: https://gerrit.osmocom.org/c/libosmo-abis/+/30280
Regarding ipa keepalive... should we remove it? it sounds like it wasn't a good idea to add it in the first place given that we have tcp keepalive. I finished up the patch for ipa keepalive and didn't realize at the time that this is redundant. I wonder if anyone is using this / and if they are, they should probably just switch to tcp keepalive. Maybe it makes sense to remove it, and add an error in the vty commands for ipa keepalive explaining that tcp keepalive can be configured instead and is even enabled by default?
Updated by osmith over 1 year ago
- Related to Bug #4070: Implement IPA PING/PONG mechanism on RSL and OML added
Updated by pespin over 1 year ago
I think those are keeplives at different stack levels and are totally compatible. One may want to have IPA keepalive and disable TCP keepalive for instance.
Updated by osmith over 1 year ago
- Status changed from Feedback to Resolved
- % Done changed from 90 to 100
Applied in changeset libosmo-abis:libosmo-abis|ef0f7c25f04573b07b6f629545881d568fe76220.
