https://osmocom.org/https://osmocom.org/favicon.ico?16647414092022-12-19T22:46:23ZOpen Source Mobile CommunicationsCellular Network Infrastructure - Bug #5809: applications disrespect potentially VTY-configured tcp/telnet porthttps://osmocom.org/issues/5809?journal_id=258372022-12-19T22:46:23Zarehbein
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Feedback</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>90</i></li></ul><p>Here's the list of repositories I created patches for (if they contained the function as a definition or call:)</p>
<ul>
<li>libosmocore</li>
<li>osmo-bsc</li>
<li>osmo-bts</li>
<li>osmo-ccid-firmware</li>
<li>osmocom-bb</li>
<li>osmo-dev</li>
<li>osmo-e1-hardware</li>
<li>osmo-gbproxy</li>
<li>osmo-gsm-manuals</li>
<li>osmo-hlr</li>
<li>osmo-asf4-dfu</li>
<li>osmo-bsc-nat</li>
<li>osmo-cbc</li>
<li>osmo-ci</li>
<li>osmocom-lcs</li>
<li>osmo-e1d</li>
<li>osmo-e1-recorder</li>
<li>osmo-ggsn</li>
<li>osmo-gsm-tester</li>
<li>osmo-hnbgw</li>
</ul> Cellular Network Infrastructure - Bug #5809: applications disrespect potentially VTY-configured tcp/telnet porthttps://osmocom.org/issues/5809?journal_id=258382022-12-20T08:17:20Zosmith
<ul></ul><p>Note: it's good practice to link related patches in the issue. In case there are a lot of patches like here, a <a href="https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit#Push-for-review" class="external">topic name</a> can be used.</p> Cellular Network Infrastructure - Bug #5809: applications disrespect potentially VTY-configured tcp/telnet porthttps://osmocom.org/issues/5809?journal_id=258392022-12-20T09:03:59Zarehbein
<ul></ul><p><a class="user active" href="https://osmocom.org/users/301771">osmith</a> I was wondering about something like that, thanks for the hint! Is it possible to change the topic by pushing for the same Change-ID, but with another topic? Also, what would a good topic be... the issue number maybe (OS_5809) ?</p> Cellular Network Infrastructure - Bug #5809: applications disrespect potentially VTY-configured tcp/telnet porthttps://osmocom.org/issues/5809?journal_id=258402022-12-20T09:10:10Zmsuraev
<ul></ul><p>arehbein wrote in <a href="#note-3">#note-3</a>:</p>
<blockquote>
<p>Is it possible to change the topic by pushing for the same Change-ID, but with another topic?</p>
</blockquote>
<p>Sure. You can change it through webUI. Or if you push via git-review it'll take branch name as a topic.</p> Cellular Network Infrastructure - Bug #5809: applications disrespect potentially VTY-configured tcp/telnet porthttps://osmocom.org/issues/5809?journal_id=258412022-12-20T10:04:47Zosmith
<ul></ul><p>arehbein wrote in <a href="#note-3">#note-3</a>:</p>
<blockquote>
<p>Also, what would a good topic be... the issue number maybe (OS_5809) ?</p>
</blockquote>
<p>That would work, or something more descriptive like telnet_init_default.</p> Cellular Network Infrastructure - Bug #5809: applications disrespect potentially VTY-configured tcp/telnet porthttps://osmocom.org/issues/5809?journal_id=258442022-12-20T14:57:00Zarehbein
<ul></ul><p>msuraev wrote in <a href="#note-4">#note-4</a>:</p>
<blockquote>
<p>arehbein wrote in <a href="#note-3">#note-3</a>:</p>
<blockquote>
<p>Is it possible to change the topic by pushing for the same Change-ID, but with another topic?</p>
</blockquote>
<p>Sure. You can change it through webUI. Or if you pish via git-review it'll take branch name as a topic.</p>
</blockquote>
<p>I tried but I suppose unless I change the patch itself, the server will reject pushing the same change with a different topic. Even for my second patchset on <code>libosmocore</code> it only worked because I used <code>git push --no-thin</code> .</p> Cellular Network Infrastructure - Bug #5809: applications disrespect potentially VTY-configured tcp/telnet porthttps://osmocom.org/issues/5809?journal_id=258882023-01-02T23:16:12Zarehbein
<ul></ul><p><a class="user active" href="https://osmocom.org/users/30187">pespin</a> I corrected the patch <a class="external" href="https://gerrit.osmocom.org/c/libosmocore/+/30703">https://gerrit.osmocom.org/c/libosmocore/+/30703</a> as requested by you, I suppose your (re-)review is needed since you put a '-1' (?)</p> Cellular Network Infrastructure - Bug #5809: applications disrespect potentially VTY-configured tcp/telnet porthttps://osmocom.org/issues/5809?journal_id=261312023-02-04T17:15:38Zarehbein
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>90</i> to <i>100</i></li></ul> Cellular Network Infrastructure - Bug #5809: applications disrespect potentially VTY-configured tcp/telnet porthttps://osmocom.org/issues/5809?journal_id=262742023-02-24T12:53:01Zfixeria
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>New</i></li><li><strong>% Done</strong> changed from <i>100</i> to <i>90</i></li></ul><p>laforge wrote:</p>
<blockquote>
<p>All the osmo-* projects need to be converted to <code>telnet_init_default()</code>.</p>
</blockquote>
<p>Unfortunately, not all projects have been updated to use the <code>telnet_init_default()</code>. I am still seeing many <code>-Wdeprecated-declarations</code> warnings when building [lib]osmo-* repositories. Even though some (not all!) callers do invoke <code>vty_get_bind_addr()</code> rather than passing port values, it's generally better to have a clean buildlog without deprecation warnings. This way it's easier to spot new warnings. Reopening this ticket.</p> Cellular Network Infrastructure - Bug #5809: applications disrespect potentially VTY-configured tcp/telnet porthttps://osmocom.org/issues/5809?journal_id=262752023-02-24T13:04:55Zfixeria
<ul><li><b>Checklist item</b> <input type='checkbox' class='checklist-checkbox' disabled> <i>osmo-uecups</i> added</li><li><b>Checklist item</b> <input type='checkbox' class='checklist-checkbox' disabled> <i>osmo-trx</i> added</li><li><b>Checklist item</b> <input type='checkbox' class='checklist-checkbox' disabled> <i>osmo-smlc</i> added</li><li><b>Checklist item</b> <input type='checkbox' class='checklist-checkbox' disabled> <i>osmo-sip-connector</i> added</li><li><b>Checklist item</b> <input type='checkbox' class='checklist-checkbox' disabled> <i>osmo-sgsn</i> added</li><li><b>Checklist item</b> <input type='checkbox' class='checklist-checkbox' disabled> <i>osmo-pcap</i> added</li><li><b>Checklist item</b> <input type='checkbox' class='checklist-checkbox' disabled> <i>osmo-msc</i> added</li><li><b>Checklist item</b> <input type='checkbox' class='checklist-checkbox' disabled> <i>osmo-mgw</i> added</li><li><b>Checklist item</b> <input type='checkbox' class='checklist-checkbox' disabled> <i>osmo-iuh (tests)</i> added</li><li><b>Checklist item</b> <input type='checkbox' class='checklist-checkbox' disabled> <i>libosmo-sccp</i> added</li><li><strong>% Done</strong> changed from <i>90</i> to <i>80</i></li></ul><p>Adding a list of repositories which still need to be updated. There might be more.</p> Cellular Network Infrastructure - Bug #5809: applications disrespect potentially VTY-configured tcp/telnet porthttps://osmocom.org/issues/5809?journal_id=262802023-02-24T16:42:34Zarehbein
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul><p>fixeria wrote in <a href="#note-10">#note-10</a>:</p>
<blockquote>
<p>Adding a list of repositories which still need to be updated. There might be more.</p>
</blockquote>
<p>Thanks for the list <a class="user active" href="https://osmocom.org/users/67">fixeria</a>, I'm on it. I listed the projects I patched initially because I wasn't sure the list was complete.</p>
<p>I don't see some (or even all?) of the projects you listed on Gerrit (screens of my output of repositories listed to me attached). Where can I find a comprehensive list of all the repositories I have access to?</p>
<p>Edit: Sorry just noticed I can't upload files with reply-edits (?)...</p> Cellular Network Infrastructure - Bug #5809: applications disrespect potentially VTY-configured tcp/telnet porthttps://osmocom.org/issues/5809?journal_id=262842023-02-24T17:27:16Zarehbein
<ul><li><strong>File</strong> <a href="/attachments/6666">gerrit_projects_screen_01.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/6666/gerrit_projects_screen_01.png">gerrit_projects_screen_01.png</a> added</li><li><strong>File</strong> <a href="/attachments/6665">gerrit_projects_screen_02.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/6665/gerrit_projects_screen_02.png">gerrit_projects_screen_02.png</a> added</li><li><strong>File</strong> <a href="/attachments/6667">gerrit_projects_screen_03.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/6667/gerrit_projects_screen_03.png">gerrit_projects_screen_03.png</a> added</li><li><strong>File</strong> <a href="/attachments/6668">gerrit_projects_screen_04.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/6668/gerrit_projects_screen_04.png">gerrit_projects_screen_04.png</a> added</li></ul><p>A screen of list of projects I see on Gerrit is attached</p> Cellular Network Infrastructure - Bug #5809: applications disrespect potentially VTY-configured tcp/telnet porthttps://osmocom.org/issues/5809?journal_id=262862023-02-24T18:32:24Zneelsnhofmeyr@sysmocom.de
<ul></ul><p>Are you aware of the "Page 1 >" in the lower right of the gerrit repos browser?<br />A better listing of all osmo repositories was the legacy <a class="external" href="https://cgit.osmocom.org/">https://cgit.osmocom.org/</a><br />However some newer repositories are not being added in cgit anymore.<br />So on the web, you're stuck with clicking throught the repository pages in gerrit,<br />but then again not all repositories live in gerrit.<br />So on the web, you're stuck with clicking through gitea: <a class="external" href="https://gitea.osmocom.org/explore/repos">https://gitea.osmocom.org/explore/repos</a><br />Not sure if all osmo repositories are mirrored to gitea (at least some of them sync only every 8 hours, i reconfigure to 15 minutes whenever i see one)</p>
<p>However, the list of important core network repositories, which I generally consider "all repositories I need to worry about", is a smaller subset. Some of use use the top-level makefile from osmo-dev.git, which clones and builds the osmo core network infrastructure, and I generally grep in all repositories that osmo-dev clones.<br /><a class="external" href="https://gitea.osmocom.org/osmocom/osmo-dev/src/branch/master/all.deps">https://gitea.osmocom.org/osmocom/osmo-dev/src/branch/master/all.deps</a></p>
<p>(I find osmo-dev.git quite helpful and convenient, maybe you also like it.<br />You can clone it and check out the readme to get started.)</p> Cellular Network Infrastructure - Bug #5809: applications disrespect potentially VTY-configured tcp/telnet porthttps://osmocom.org/issues/5809?journal_id=262872023-02-24T18:37:24Zarehbein
<ul></ul><p><a class="user active" href="https://osmocom.org/users/91">neels</a> thanks. I don't know why I only skipped through the first two pages, today and back then, even though the arrow kept showing. The list in osmo-dev sounds useful for getting all names for the clones, thanks.</p> Cellular Network Infrastructure - Bug #5809: applications disrespect potentially VTY-configured tcp/telnet porthttps://osmocom.org/issues/5809?journal_id=262902023-02-25T18:15:21Zarehbein
<ul><li><b>Checklist item</b> <input type='checkbox' class='checklist-checkbox' checked disabled> <i>osmo-uecups</i> set to Done</li><li><b>Checklist item</b> <input type='checkbox' class='checklist-checkbox' checked disabled> <i>osmo-smlc</i> set to Done</li><li><b>Checklist item</b> <input type='checkbox' class='checklist-checkbox' checked disabled> <i>osmo-sip-connector</i> set to Done</li><li><b>Checklist item</b> <input type='checkbox' class='checklist-checkbox' checked disabled> <i>osmo-sgsn</i> set to Done</li><li><b>Checklist item</b> <input type='checkbox' class='checklist-checkbox' checked disabled> <i>osmo-pcap</i> set to Done</li><li><b>Checklist item</b> <input type='checkbox' class='checklist-checkbox' checked disabled> <i>osmo-msc</i> set to Done</li><li><b>Checklist item</b> <input type='checkbox' class='checklist-checkbox' checked disabled> <i>osmo-mgw</i> set to Done</li><li><b>Checklist item</b> <input type='checkbox' class='checklist-checkbox' checked disabled> <i>osmo-iuh (tests)</i> set to Done</li><li><b>Checklist item</b> <input type='checkbox' class='checklist-checkbox' checked disabled> <i>libosmo-sccp</i> set to Done</li><li><strong>% Done</strong> changed from <i>80</i> to <i>90</i></li></ul><p>I went through repositories from <code>osmo-dev/all.deps</code> and pushed fixes to topic 'os5809':</p>
<p><a class="external" href="https://gerrit.osmocom.org/q/topic:os5809">https://gerrit.osmocom.org/q/topic:os5809</a></p>
<p>osmo-trx fails on the endianness test. I tried to rebase to see if that's the problem but Gerrit tells me the branch is up to date. Not sure what the problem is, the endianness test isn't run as part of <code>make check</code> in osmo-trx itself, looks like something 'exclusive' from osmo-ci. <del>I took a first look at the project but couldn't quickly find how exactly endianness tests are run/how I could run them to debug stuff live.</del><br />Running <code>./contrib/jenkins.sh</code> from <code>osmo-trx</code> doesn't work for me, had to install dependencies and I stopped when one of the calls to configure inside the script kept asking for the package LimeSuite - installing <code>llimesuite limesuite-dbgsym</code>, then <code>limesuite-udev</code> via <code>apt-get</code> didn't work.</p>
<p>Maybe someone else knows what the problem is? General compilation seems to work out after all, and the jenkins script downloads a current libosmocore.</p>
<p>Maybe the code in <code>osmo-trx/Transceiver52M</code> still links against an older version of libosmocore before the API change? Not sure how to look that up. I'm not sure how to find out where the binaries for <code>Transceiver52M/osmo-trx.cpp</code> land to check on linkage, either. I couldn't find any such binaries in the repository directory.<br />Don't know much about the 'compilation layout', tried looking at <code>Transceiver52M/Makefile.am</code>, but there's probably some better way of trying to understand build layout with autotools that I don't yet know.</p>
<p>Link to failed test:<br />[endianness] <a class="external" href="https://jenkins.osmocom.org/jenkins/job/gerrit-pipeline-endianness/176/consoleFull">https://jenkins.osmocom.org/jenkins/job/gerrit-pipeline-endianness/176/consoleFull</a></p> Cellular Network Infrastructure - Bug #5809: applications disrespect potentially VTY-configured tcp/telnet porthttps://osmocom.org/issues/5809?journal_id=262922023-02-26T09:04:39Zfixeria
<ul></ul><p>arehbein wrote in <a href="#note-15">#note-15</a>:</p>
<blockquote>
<p>osmo-trx fails on the endianness test. I tried to rebase to see if that's the problem but Gerrit tells me the branch is up to date. Not sure what the problem is, the endianness test isn't run as part of <code>make check</code> in osmo-trx itself, looks like something 'exclusive' from osmo-ci. <del>I took a first look at the project but couldn't quickly find how exactly endianness tests are run/how I could run them to debug stuff live.</del></p>
</blockquote>
<p>It's a bit more complicated. Looking at the build log, I see <code>struct_endianness.py</code> is crashing:</p>
<pre>
UnicodeDecodeError: 'utf-8' codec can't decode byte 0x80 in position 25144: invalid start byte
</pre>
<p>while processing a file in <strong>osmocom-bb submodule</strong> of <code>osmo-trx.git</code>. <code>osmocom-bb.git</code> has been fixed by <a class="external" href="https://gerrit.osmocom.org/q/I0daebccf819595ee64fb4c9713a4f0ce219c58be">https://gerrit.osmocom.org/q/I0daebccf819595ee64fb4c9713a4f0ce219c58be</a>, but the submodule is at <code>040bf4102892ddba1a4574d85b31653131c5ede4</code>, predating this commit.</p>
<p>We can update the submodule, but I believe <code>struct_endianness.py</code> needs to be fixed, so that it does not crash but skip files it fails to process. I'll submit a patch.</p> Cellular Network Infrastructure - Bug #5809: applications disrespect potentially VTY-configured tcp/telnet porthttps://osmocom.org/issues/5809?journal_id=262962023-02-26T19:53:10Zarehbein
<ul></ul><p><a class="user active" href="https://osmocom.org/users/67">fixeria</a> alright, so I'll either wait until your patch is in osmocom-bb, and then update the submodule<br />or update it now to some commit. What do you suggest?</p>
<p>Question would also be which commit to choose I suppose.</p> Cellular Network Infrastructure - Bug #5809: applications disrespect potentially VTY-configured tcp/telnet porthttps://osmocom.org/issues/5809?journal_id=262992023-02-27T08:19:45Zosmith
<ul></ul><p>Regarding that CI error: it's best if the struct endianness check ignores the submodules, fixed it here: <a class="external" href="https://gerrit.osmocom.org/c/osmo-ci/+/31535">https://gerrit.osmocom.org/c/osmo-ci/+/31535</a></p>
<p>With that, CI for your osmo-trx patch should be passing, I've retriggered it.</p> Cellular Network Infrastructure - Bug #5809: applications disrespect potentially VTY-configured tcp/telnet porthttps://osmocom.org/issues/5809?journal_id=263032023-02-28T10:28:39Zarehbein
<ul><li><b>Checklist item</b> <input type='checkbox' class='checklist-checkbox' checked disabled> <i>osmo-trx</i> set to Done</li></ul> Cellular Network Infrastructure - Bug #5809: applications disrespect potentially VTY-configured tcp/telnet porthttps://osmocom.org/issues/5809?journal_id=263552023-03-13T17:18:07Zarehbein
<ul><li><b>Checklist item</b> <input type='checkbox' class='checklist-checkbox' disabled> <i>osmo-trx</i> set to Not done</li></ul> Cellular Network Infrastructure - Bug #5809: applications disrespect potentially VTY-configured tcp/telnet porthttps://osmocom.org/issues/5809?journal_id=263572023-03-13T17:19:22Zarehbein
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>90</i> to <i>100</i></li></ul> Cellular Network Infrastructure - Bug #5809: applications disrespect potentially VTY-configured tcp/telnet porthttps://osmocom.org/issues/5809?journal_id=263772023-03-17T15:10:39Zpespin
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Feedback</i></li></ul><p>Re-opening since I still see deprecation warning in osmo-bsc/src/osmo-bsc/neighbor_ident.c:</p>
<pre>
CC neighbor_ident.lo
neighbor_ident.c: In function 'neighbor_controlif_setup':
neighbor_ident.c:493:2: warning: 'ctrl_interface_setup_dynip2' is deprecated: For internal use inside libosmocore only. [-Wdeprecated-declarations]
493 | return ctrl_interface_setup_dynip2(net, net->neigh_ctrl.addr, net->neigh_ctrl.port,
| ^~~~~~
In file included from neighbor_ident.c:37:
/usr/local/include/osmocom/ctrl/control_if.h:45:21: note: declared here
45 | struct ctrl_handle *ctrl_interface_setup_dynip2(void *data,
|
</pre> Cellular Network Infrastructure - Bug #5809: applications disrespect potentially VTY-configured tcp/telnet porthttps://osmocom.org/issues/5809?journal_id=263782023-03-17T17:38:38Zarehbein
<ul><li><strong>Assignee</strong> changed from <i>arehbein</i> to <i>msuraev</i></li></ul><p><a class="user active" href="https://osmocom.org/users/119">msuraev</a> do you maybe still have a patch for that sitting in one of your working trees that you forgot to upload? <a class="user active" href="https://osmocom.org/users/30187">pespin</a> this was another interface Max was working on (where he tagged this issue as related <a class="external" href="https://gerrit.osmocom.org/c/libosmocore/+/30444">https://gerrit.osmocom.org/c/libosmocore/+/30444</a>).</p>
<p>If Max doesn't have anything, I can of course also fix this up. Just keep me posted</p> Cellular Network Infrastructure - Bug #5809: applications disrespect potentially VTY-configured tcp/telnet porthttps://osmocom.org/issues/5809?journal_id=263792023-03-18T13:21:16Zmsuraev
<ul></ul><p>arehbein wrote in <a href="#note-23">#note-23</a>:</p>
<blockquote>
<p><a class="user active" href="https://osmocom.org/users/119">msuraev</a> do you maybe still have a patch for that sitting in one of your working trees that you forgot to upload? <a class="user active" href="https://osmocom.org/users/30187">pespin</a> this was another interface Max was working on (where he tagged this issue as related <a class="external" href="https://gerrit.osmocom.org/c/libosmocore/+/30444">https://gerrit.osmocom.org/c/libosmocore/+/30444</a>).</p>
<p>If Max doesn't have anything, I can of course also fix this up. Just keep me posted</p>
</blockquote>
<p>That's deprecated interface which should not be used anyway so there's no point updating it. I'll submit patch removing this altogether.</p> Cellular Network Infrastructure - Bug #5809: applications disrespect potentially VTY-configured tcp/telnet porthttps://osmocom.org/issues/5809?journal_id=267222023-04-15T11:43:26Zmsuraev
<ul><li><b>Checklist item</b> <input type='checkbox' class='checklist-checkbox' disabled> <i>osmo-bsc</i> added</li><li><strong>% Done</strong> changed from <i>100</i> to <i>90</i></li></ul><p><a class="external" href="https://gerrit.osmocom.org/c/osmo-pcu/+/32275">https://gerrit.osmocom.org/c/osmo-pcu/+/32275</a> and<br /><a class="external" href="https://gerrit.osmocom.org/c/osmo-bsc/+/32277">https://gerrit.osmocom.org/c/osmo-bsc/+/32277</a><br />are removing obsolete ctrl interface for neighbor resolution and thus get rid of deprecated ctrl init used by it.</p> Cellular Network Infrastructure - Bug #5809: applications disrespect potentially VTY-configured tcp/telnet porthttps://osmocom.org/issues/5809?journal_id=283682023-10-31T09:34:58Zlaforge
<ul><li><strong>Assignee</strong> changed from <i>msuraev</i> to <i>osmith</i></li></ul>