Actions
Bug #5832
closedos2gbts_mgr_calib does not compile in OE
Start date:
12/16/2022
Due date:
% Done:
100%
Spec Reference:
Description
| ERROR: oe_runmake failed | ../../../git/src/osmo-bts-oc2g/misc/oc2gbts_mgr_calib.c: In function 'mgr_gps_checkfix': | ../../../git/src/osmo-bts-oc2g/misc/oc2gbts_mgr_calib.c:174:2: error: aggregate value used where an integer was expected | mgr->gps.gps_fix_now = (time_t) data->fix.time;
data is a struct gps_data_t from gpsd
gpsd version is gpsd-3.24-r0 from OpenEmbedded
From the gpsd git history it looks like data->fix.time has always been a struct timespec, but this patch:
https://gerrit.osmocom.org/c/osmo-bts/+/30638
fails with
misc/oc2gbts_mgr_calib.c:174:39: error: request for member ‘tv_sec’ in something not a structure or union mgr->gps.gps_fix_now = data->fix.time.tv_sec;
Updated by laforge over 1 year ago
- Assignee set to osmith
assigning to osmith, as he did the gpsd upgrade and modified gpsdate to adhere to the gpsd API changes. The code was compiling with our previous/older gpsd versions.
Updated by osmith over 1 year ago
- % Done changed from 0 to 90
The API change was in 3.20, https://gitlab.com/gpsd/gpsd/-/blob/release-3.20/gps.h#L63:
Change gps_fix_t.time from timestamp_t to timespec_t
I've updated the patch.
Updated by osmith over 1 year ago
- Status changed from In Progress to Resolved
- % Done changed from 90 to 100
Applied in changeset osmo-bts|73773447715c57075ad5acb96a5346ff23d7e91f.
Actions