Actions
Bug #5866
closedosmo-bsc: Fix neighbor cfg check only being run in osmo_bsc_main.c
Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
01/20/2023
Due date:
% Done:
100%
Spec Reference:
Description
When configuring neighbors for a BTS through the local BTS number, for example as in
... bts 1 ... neighbor bts <some number> ... ...
neighbors_check_cfg is only called after the config parser in src/osmo-bsc/osmo_bsc_main.c has run. This is probably why on implementation on the CTRL command apply-config-file, this wasn't added as part of the config parser, resulting in different behavior between startup and runtime behavior exposed by CTRL w.r.t. config parsing.
Updated by arehbein 13 days ago
- Status changed from New to Feedback
- % Done changed from 0 to 80
Uploaded a patch to Gerrit. From my understanding, this should be a fix.
The differences in control flow betweensrc/osmo-bsc/bsc_ctrl.c and src/osmo-bsc/osmo_bsc_main.c now are, that the latter calls bsc_network_configure() which in turn
- calls
vty_read_config_fileinstead ofvty_read_config_filep(what we want, because the essential difference between these functions is that the config file is set invty_read_config_file) - registers signal handlers which shouldn't be needed to be registered when parsing config snippets through CTRL
- tries to bootstrap BTS logic/drivers for that logic
I'm not entirely sure if the last point shouldn't also be considered when applying config files through CTRL, so input on this would be appreciated.
Actions
