Project

General

Profile

Actions

Bug #5879

closed

Fix 'make distclean' (or add 'make maintainer-clean'?)

Added by arehbein about 1 year ago. Updated 4 days ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
01/27/2023
Due date:
% Done:

0%

Spec Reference:

Description

Running ./configure with --enable-sanitize and then make-ing leaves a couple of files in osmo-bsc/m4 (probably along with a couple of other files) that are not cleaned up by make distclean. Seems like it's a common problem that files in .gitignore aren't cleaned up by that command.

Those files in osmo-bsc/m4 can lead to linker problems unresolvable by make distclean, because the --enable-sanitize flag is not properly cleaned up.

In my case, I ran docker-playground/ttcn3-bsc-test/jenkins.sh with a modified docker image (in the sense that the Dockerfile points to a copy of my local repository) and got a compilation error (I think because libosmocore inside the Docker image was built without the sanitizer, not sure though).
Only manually fixing this by running rm m4/l* in osmo-bsc repo root dir helped.

Actions #1

Updated by arehbein about 1 year ago

.. to be more precise: Instead of

with a modified docker image

I should have written

with a modified Dockerfile

Actions #2

Updated by fixeria 4 days ago

  • Status changed from New to Rejected

The files in directory m4 are generated by autoreconf, so make distclean would indeed not touch them.

Those files in osmo-bsc/m4 can lead to linker problems unresolvable by make distclean, because the --enable-sanitize flag is not properly cleaned up.

I don't see how this could be related. The files in directory m4 have nothing to do with the configure flags.

Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)