Bug #5886
closedDoesn't build without CONFIG_DAHDI_MIRROR
100%
Description
When attempting to build osmo-isdntap with dahdi-linux 1:2.11.1~dfsg-1ubuntu11, it fails with:
dahdi.c:230:26: error: ‘DAHDI_RXMIRROR’ undeclared (first use in this function); did you mean ‘DAHDI_MAJOR’? 230 | rc = make_mirror(DAHDI_RXMIRROR, sig_ts->drvdata.dahdi.channo); | ^~~~~~~~~~~~~~ | DAHDI_MAJOR dahdi.c:230:26: note: each undeclared identifier is reported only once for each function it appears in dahdi.c:240:26: error: ‘DAHDI_TXMIRROR’ undeclared (first use in this function); did you mean ‘DAHDI_TIMERPONG’? 240 | rc = make_mirror(DAHDI_TXMIRROR, sig_ts->drvdata.dahdi.channo); | ^~~~~~~~~~~~~~ | DAHDI_TIMERPONG dahdi.c: In function ‘open_ts_dahdi’: dahdi.c:265:26: error: ‘DAHDI_RXMIRROR’ undeclared (first use in this function); did you mean ‘DAHDI_MAJOR’? 265 | rc = make_mirror(DAHDI_RXMIRROR, ts->drvdata.dahdi.channo); | ^~~~~~~~~~~~~~ | DAHDI_MAJOR dahdi.c:274:26: error: ‘DAHDI_TXMIRROR’ undeclared (first use in this function); did you mean ‘DAHDI_TIMERPONG’? 274 | rc = make_mirror(DAHDI_TXMIRROR, ts->drvdata.dahdi.channo); | ^~~~~~~~~~~~~~ | DAHDI_TIMERPONG
It looks like dahdi needs to be built with CONFIG_DAHDI_MIRROR for the defines to be present.
This does not seem to be the default here:
https://github.com/asterisk/dahdi-linux/blob/4397c55319154a8dc89022f6f75c683d6af12d54/include/dahdi/dahdi_config.h#L190
Also in debian packaging it looks like this isn't enabled:
https://salsa.debian.org/pkg-voip-team/dahdi-linux/-/tree/master/
Updated by laforge about 1 year ago
On Wed, Feb 01, 2023 at 09:44:26AM +0000, osmith wrote:
It looks like dahdi needs to be built with CONFIG_DAHDI_MIRROR for the defines to be present.
yes, this is correct.
This does not seem to be the default here:
https://github.com/asterisk/dahdi-linux/blob/4397c55319154a8dc89022f6f75c683d6af12d54/include/dahdi/dahdi_config.h#L190
no, but it is the default in our git.osmocom.org dahdi-linux, which is what is used in context
with this code. Still, the configure.ac should check for DAHDI_RXMIRROR and give a meaningful
error if it is not enabled before even tryin to build.