Actions
Bug #5943
closedseveral ttcn3 tests failing after merge of pcu_sock: activate/deactivate PDCH on pcu reconnect
Start date:
03/08/2023
Due date:
% Done:
100%
Spec Reference:
Description
As discussed, I've looked into getting ttnc3-bsc-tests to 100% passing again. Besides TC_ho_in_fail_no_detect (patch) everything was passing yesterday. Today several tests fail with:
Timeout expecting { msg_disc := { msg_group := RSL_MDISC_DCHAN (4), transparent := false }, msg_type := RSL_MT_IPAC_PDCH_ACT (72), ies := { { iei := ?, body := { chan_nr := { u := { ch0 := RSL_CHAN_NR_Bm_ACCH (1) }, tn := 6 } } } } } BSC_Tests.ttcn:12428 BSC_Tests control part BSC_Tests.ttcn:7886 TC_dyn_pdch_ipa_act_deact testcase
git bisect points to:
ecf825dc0856411df3b83737d9439de044823d1b is the first bad commit commit ecf825dc0856411df3b83737d9439de044823d1b Author: Philipp Maier <pmaier@sysmocom.de> Date: Fri Feb 24 14:50:11 2023 +0100 pcu_sock: activate/deactivate PDCH on pcu reconnect When the PCU is disconnected while the BSC keeps running the PDCH should be closed. Also the PDCH should be reopened when the PCU is reconnected. Change-Id: I9ea0c53a5e68a51c781ef43bae71f947cdb95678 Related: OS#5198 doc/timeslot.msc | 20 ++++++++++++++++- include/osmocom/bsc/pcu_if.h | 3 +++ include/osmocom/bsc/timeslot_fsm.h | 11 ++++++++++ src/osmo-bsc/pcu_sock.c | 44 +++++++++++++++++++++++++++----------- src/osmo-bsc/timeslot_fsm.c | 37 ++++++++++++++++++++++++++++++++ 5 files changed, 102 insertions(+), 13 deletions(-) bisect found first bad commit
So assigning dexter to it, please take a look when you have time.
Actions