Osmocom Libraries » libosmocore

The patch in question still seems correct, as libosmocoding does not use talloc.

I guess the problem is that libosmocoding Makefile doesn't seem to be "depending" on libosmocore cflags, despite it using libosmocore.

If libosmocoding would be a separate library, it should be using pkg-config --cflags libosmocore which due to the dependency of libosmocore.pc to talloc would add the talloc include path.

I'm not entirely sure what is the correct solution for the situation at hand, where libosmocoding is not a separate package but built as part of the libosmocore build process.

Hi Mychaela,

falconia wrote:

This recent commit that has been merged on 2023-03-11:

https://cgit.osmocom.org/libosmocore/commit/?id=9dca9027b75b706f333ede584beb09143cb98cbd

breaks the build of libosmocore under Slackware 14.2.

sorry for inconvenience, I submitted a partial revert adding $(TALLOC_CFLAGS) back:

https://gerrit.osmocom.org/c/libosmocore/+/32166 fixup (partial revert): "coding: clean up Makefile.am" [NEW]

Factor 1: libosmocore header files are so intertwined (include each other freely) that no matter which part of libosmocore you are actually interested in, or more specifically no matter which libosmocore header you are including, <osmocom/core/talloc.h> will always get pulled in no matter what.

I also submitted a patch removing unnecessary includes of talloc.h from some header files:

https://gerrit.osmocom.org/c/libosmocore/+/32167 core: remove unnecessary #include <osmocom/core/talloc.h> [NEW]

Removing it from osmocom/core/utils.h is impossible because it has inline functions using talloc API.

Factor 3: the voodoo magic of autotools plus pkg-config is able to find this deeply-hidden talloc.h on my system, and it correctly sets TALLOC_CFLAGS to the needed -I path.

Perhaps because the pkg-config manifest talloc.pc lives in the standard location for your distro, unlike the header file.

Factor 4: because of intertwined libosmocore header files (see Factor 1 above), practically every Osmocom sw component must include TALLOC_CFLAGS in its Makefile.am CFLAGS or CPPFLAGS, or else the build breaks. It appears that this rule has been followed by all Osmocom projects up until now, as I haven't run into this issue until this very recent libosmocore commit breaking src/coding.

No, this is not entirely correct. Other projects don't really need to put TALLOC_CFLAGS into their CFLAGS/CPPFLAGS because libosmocore.pc.in explicitly lists talloc as a dependency, so LIBOSMOCORE_CFLAGS will additionally contain talloc's CFLAGS. This is all autotools magic...

This commit in libosmocore master fixes the broken build:

https://cgit.osmocom.org/libosmocore/commit/?id=48c60f97714581e53de068b4a1b7c0d70bd41fdf

The present issue can now be closed.