Cellular Network Infrastructure » Core Network (CN) » OsmoHNBGW

There is a hnbgw_cnlink->state member and a cnlink state machine concerned with sending RESET to RANAP/SCCP peers,
but the cnlink->state member is never set, this seems to be missing in hnbgw_cnlink_change_state().
We also never use its value, neither in state changes nor for vty_out().

It was like this ever since it was first created, see osmo-iuh.git 90256bad581a77069e0e9232927111f677a15272 and c4338deee9f3928eae61689687a1ff7ffee0d7b8 (in 2015, before migrating to a separate osmo-hnbgw.git)

Apparently all that is really needed is an event dispatch for CNLINK_S_EST_CONF, CNLINK_S_EST_RST_TX_WAIT_ACK and CNLINK_S_EST_ACTIVE
(see hnbgw_cnlink_change_state() in hnbgw_cn.c)

Figure out and verify that we can simply drop this parameter, and maybe replace the enum with simple direct function calls?