Project

General

Profile

Actions

Bug #6130

closed

Feature #5500: MS-Side GPRS RLC/MAC implementation

modem: Fix Submitting CCCH_DATA.ind with hardcoded fn=0 to libosmo-gprs-rlcmac

Added by pespin 9 months ago. Updated 8 months ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
OsmocomBB mobile (host)
Target version:
-
Start date:
08/02/2023
Due date:
% Done:

100%

Resolution:
Spec Reference:

Description

Right now osmocom-bb's modem app is submitting a hardcoded fn=0 to the RLC/MAC layer when submitting CCCH-DATA.ind:

static int forward_to_rlcmac(struct osmocom_ms *ms, struct msgb *msg)
{
    struct osmo_gprs_rlcmac_prim *rlcmac_prim;

    /* Forward SI13 to RLC/MAC layer */
    rlcmac_prim = osmo_gprs_rlcmac_prim_alloc_l1ctl_ccch_data_ind(0 /* TODO: fn */, msgb_l3(msg));
    return osmo_gprs_rlcmac_prim_lower_up(rlcmac_prim);
}

This is of course wrong and has to be fixed to provide the current FN from the scheduler, since RLC/MAC needs it for instance when receiving a CCCH ImmAss[PktUlAss[SingleBlkAlloc]] which contains an RFN, and which hence needs to be transformed to an absolute fn using curr_fn + rfn.


Related issues

Blocked by libosmocore - Bug #3626: LAPDm code pulls both 'l1h' and 'l2h' of msgbResolvedpespin10/04/2018

Actions
Actions #1

Updated by pespin 9 months ago

  • Priority changed from Normal to High
Actions #2

Updated by pespin 9 months ago

This commit needs this feature in order to work:
https://gerrit.osmocom.org/c/libosmo-gprs/+/34046 rlcmac: ul_tbf: Implement TBF_Starting time (phase1)

The case can be easily tested by forcing osmo-pcu to use 2-phase acces (VTY config "two-phase-access").

Actions #3

Updated by fixeria 9 months ago

  • Blocked by Bug #3626: LAPDm code pulls both 'l1h' and 'l2h' of msgb added
Actions #4

Updated by pespin 8 months ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 90

This is being fixed here: https://gerrit.osmocom.org/c/osmocom-bb/+/34133/6

Once merged this ticket can be closed.

Actions #5

Updated by pespin 8 months ago

  • Assignee changed from fixeria to pespin
Actions #6

Updated by pespin 8 months ago

  • Status changed from Feedback to Resolved
  • % Done changed from 90 to 100

Merged, closing.

Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)