Project

General

Profile

Actions

Bug #6185

open

Submit titan.ProtocolEmulations.SCCP patch upstream

Added by pespin 7 months ago. Updated 7 months ago.

Status:
New
Priority:
Normal
Assignee:
Target version:
-
Start date:
09/20/2023
Due date:
% Done:

0%

Spec Reference:

Description

It was noticed that we currently hold & use in osmo-ttcn3-hacks our own fork of titan.ProtocolEmulations.SCCP.git [1].

We use our own fork because we are using an extra patch on top of master [2]. AFAICT, that patch has never been submitted upstream, but at first glance it looks like it should?

The upstream to submit to is in gitlab [3].

[1] https://github.com/osmocom/titan.ProtocolEmulations.SCCP
[2] https://github.com/osmocom/titan.ProtocolEmulations.SCCP/commit/17a894fc6620a0df11d0d98c897fb66168276b16
[3] https://gitlab.eclipse.org/eclipse/titan/titan.ProtocolEmulations.SCCP

Actions #1

Updated by pespin 7 months ago

neels FYI I just updated our git fork https://github.com/osmocom/titan.ProtocolEmulations.SCCP:
- I made your patch lay on branch "osmocom/master" instead of "master"
- I updated our "master" branch to upstream's "master" branch
- I rebased our "osmocom/master" (your patch) on top of current upstream master.

I also updated osmo-ttcn3-hacks.git/deps/Makefile to point to our new "osmocom/master" git hash: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34468

I did that because I needed a patch I submitted in upstream which was already merged, and which will be needed by some tests I'm adding.

So what's left still, is that you submit the patch to upstream, which is already properly rebased now. In order to do that, you need to sign in into eclipse gitlab instance, fork the upstream repo, submit your patch to your gitlab fork and then use the gitlab UI to submit a PR.

Actions #2

Updated by neels 7 months ago

nice, Thanks!

Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)