Project

General

Profile

Actions

Bug #6238

closed

Release new version of osmo_diameter2gsup

Added by daniel 4 months ago. Updated 4 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
Start date:
10/30/2023
Due date:
% Done:

100%


Description

Current version 0.1.3 of osmo_diameter2gsup is missing commit 7c912ff07b6fe3c91b90d0b9729bdc159da6165d which handles decoding of the APN value. If you download the tar.xz there is no src/decode_apn.erl file:

https://obs.osmocom.org/source/osmocom:latest/osmo_dia2gsup/osmo-diameter2gsup_0.1.3.tar.xz?rev=c25caecb837ba4132713daf783df7793

The logs show that the APN is not decoded (Line breaks for emphasis):

Oct 30 14:31:27 sysmonitb osmo-dia2gsup[672]: 14:31:27.951 [info] GsupRxIsdReq: #{cn_domain => 1,imsi => <<"999700000070664">>,message_type => insert_sub_data_req,msisdn => <<3,7,102,244>>,pdp_info_list => [

#{access_point_name => <<7,100,101,102,97,117,108,116>>,pdp_context_id => 1},

#{access_point_name => <<"\binternet">>,pdp_context_id => 2},#{access_point_name => <<1,42>>,pdp_context_id => 3}]}
[...]
Oct 30 14:31:27 sysmonitb osmo-dia2gsup[672]: 14:31:27.958 [info] ULR Resp: {'ULA',"mme.localdomain;1698675596;2;app_s6a",1,"hss.localdomain","localdomain",[],2001,[],[],0,{'Subscription-Data',0,<<3,7,102,244>>,[],[],[],0,[],[],[],[],[],[],[],[],[],{'AMBR',100000000,100000000,[]},{'APN-Configuration-Profile',1,0,[{'APN-Configuration',1,0,"internet",[],{'EPS-Subscribed-QoS-Profile',9,{'Allocation-Retention-Priority',8,1,1},[]},[],[],[],[],[],{'AMBR',100000000,100000000,[]},[],[],[],[],[],[]},{'APN-Configuration',2,0,"internet",[],{'EPS-Subscribed-QoS-Profile',9,{'Allocation-Retention-Priority',8,1,1},[]},[],[],[],[],[],{'AMBR',100000000,100000000,[]},[],[],[],[],[],[]},{'APN-Configuration',3,0,"internet",[],{'EPS-Subscribed-QoS-Profile',9,{'Allocation-Retention-Priority',8,1,1},[]},[],[],[],[],[],{'AMBR',100000000,100000000,[]},[],[],[],[],[],[]}],[]},[],[],{'GPRS-Subscription-Data',0,[

{'PDP-Context',1,<<0,0,0,33>>,<<0,0,0,0,0,0,0,0,0,0,0,0,0,0>>,<<7,100,101,102,97,117,108,116>>,[],[],[],[],[],[],[],[],[],[],[]},

{'PDP-Context',2,<<0,0,0,33>>,<<0,0,0,0,0,0,0,0,0,0,0,0,0,0>>,<<"\binternet">>,[],[],[],[],[],[],[],[],[],[],[]},{'PDP-Context',3,<<0,0,0,33>>,<<0,0,0,0,0,0,0,0,0,0,0,0,0,0>>,<<1,42>>,[],[],[],[],[],[],[],[],[],[],[]}],[]},[],[],[],[],[],[],[],[],[],[]},[],[],[],[],[]}

GSUP returns APN "\x07default"
#{access_point_name => <<7,100,101,102,97,117,108,116>>,pdp_context_id => 1}
this is not decoded when passed to diameter
{'PDP-Context',1,<<0,0,0,33>>,<<0,0,0,0,0,0,0,0,0,0,0,0,0,0>>,<<7,100,101,102,97,117,108,116>>

Latest version tag I can find in the repository is 0.1.2.

Ping lynxis, pespin

Actions #1

Updated by daniel 4 months ago

  • File deleted (clipboard-202310301607-76egl.png)
Actions #2

Updated by osmith 4 months ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 90

https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34928

I've wondered if we should also include https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34285, but it doesn't seem to be ready according to review comments (?) and we could just tag another version once this is in.

I've used 0.2.0 instead of 0.1.x, because there was a backport release for 0.1.x that wasn't in master.

Actions #3

Updated by osmith 4 months ago

  • Status changed from In Progress to Resolved
  • % Done changed from 90 to 100

Done.

For future reference, doing this is documented here (search for osmo_dia2gsup):
https://osmocom.org/projects/cellular-infrastructure/wiki/Make_a_new_release#Release-steps

Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)