Bug #6331
closedRegression in update_binary_decoded
100%
Description
I have been encountering an issue with update_binary_decoded, not accepting text values as documented. The regression, compared to documented behavior appears to be here: https://gitea.osmocom.org/sim-card/pysim/blame/branch/master/pySim/filesystem.py#L625
example:
pySIM-shell (00:MF/ADF.USIM/EF.IMSI)> update_binary_decoded '{ "imsi": "111111111111111" }'
usage: update_binary_decoded [-h] [--json-path JSON_PATH] data
update_binary_decoded: error: argument data: invalid is_hexstr value: '{ "imsi": "111111111111111" }'
pySIM-shell (00:MF/ADF.USIM/EF.IMSI)> update_binary_decoded --json-path imsi "111111111111111"
usage: update_binary_decoded [-h] [--json-path JSON_PATH] data
update_binary_decoded: error: argument data: invalid is_hexstr value: '111111111111111'
pySIM-shell (00:MF/ADF.USIM/EF.IMSI)>
Updated by fixeria 4 months ago
- Assignee set to laforge
Most likely a regression of https://gerrit.osmocom.org/c/pysim/+/35551. IMSI is 15-digits, while is_hexstr()
expects even number of digits.
Updated by laforge 4 months ago
Should be fixed in https://gerrit.osmocom.org/c/pysim/+/35612 - sorry for that regression.