Bug #5329
Updated by laforge over 2 years ago
This is a somewhat questionable API decision and we need to audit our code base accordingly.
h2. functions that do it correctly
* ctrl_cmd_send
* osmo-bsc:bsc_rf_ctrl.c:send_resp
* osmo-bsc:meas_feed.c:process_meas_rep
* osmo-mgw:mgcp_client_tx
* osmo-msc:smpp_smsc.c:pack_and_send
* osmo-msc:smpp_mirror.c:pack_and_send
* osmo-pcap:osmo_client_network.c:write_data
* osmo-pcu:osmo-bts-*/*_l1_if.c
* osmcoom-bb:layer23:osmo_send_l1
* osmocom-bb:layer23:sap_fsm:sap_send_msgb
h2. functions that get it wrong
* osmo-bts:osmo-bts-{lc15,oc2g,octphy}/*_l1_if.c:ph_tch_req
* osmo-iuh/src/tests/hnb-test.c (just a test cse)
h2. functions that pass return value of osmo_wqueue_enqueue* up to caller
We need to trace the usage of those...
* gsmtap_sendmsg
* gsmtap_send_ex
* gsmtap_send
* tcap_tp_udp_unitdata_req
* tcap_scXp_n_unitdata_req
* osmo-el2tpd:l2tp_socket_enqueue