Project

General

Profile

Bug #1829

Fix warnings introduced by ctrl constify

Added by msuraev over 4 years ago. Updated almost 3 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
10/19/2016
Due date:
% Done:

0%

Spec Reference:

Description

Commit ed9d6da5df98538adc70aa03cb569eb9505d04b6 in libosmocore changes some part of ctrl_cmd struct to const. This is necessary to avoid additional warnings in OpenGGSN ctrl-related code. Regrettably, this results in numerous warnings in OpenBSC du to use of strtok_r for parsing of ctrl_cmd fields.

This should be fixed as follows:
- add unit (or python) tests for functions which have those warnings in OpenBSC
- replace (maybe using some helper functions) direct strtok_r parsing with code working with copies (talloc_strdup?)
- check that tests still pass
- double-check for memleaks

Associated revisions

Revision 694f72d1 (diff)
Added by neels over 4 years ago

Revert "Constify ctrl_cmd struct fields where appropriate"

This reverts commit ed9d6da5df98538adc70aa03cb569eb9505d04b6.

The commit is good as such, but it causes many compiler warnings in the OpenBSC
build. We want this to be re-applied as soon as we have patches ready that fix
the fallout in openbsc.git.

See also https://lists.osmocom.org/pipermail/openbsc/2016-October/009802.html

Related: OS#1829
Change-Id: I722ad60232a6ef5b4cb984b92c42851de26b3ccd

History

#2 Updated by laforge almost 3 years ago

  • Project changed from OpenBSC to OsmoNITB

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)