Bug #1906
openwireshark: fix decoding of (E)GPRS RLC/MAC frames
0%
Description
The RLC/MAC frames contained in DIAG are currently not correctly displayed, I assume it is some kind of bit alignment/padding issue.
dissect_qcdiag_log_gmac() in http://git.osmocom.org/wireshark/tree/epan/dissectors/packet-qcdiag_log.c?h=laforge/qcdiag maybe needs the same kind of bit-fucking like implemented in http://git.osmocom.org/wireshark/commit/?h=laforge/qcdiag&id=270c4e66fee78aa1a79f6b3ff4dc445a2521e6dd and the related code should thus be added to the rlc/mac dissector (registering a new dissector for differently aligned frames?) rather than to packet-gsmtap.c, packet-qcdiag_log.c and packet-gsm_abis_pgsl.c
Updated by laforge about 3 years ago
- Assignee changed from laforge to pespin
I think this was fixed by pespin meanwhile?
Updated by pespin about 3 years ago
- Assignee changed from pespin to laforge
I would say in general decoding of egprs rlcmac frames has improved a lot, at least when used with GSMTAP. There may still be some small issues here and there but I think it's better oening specific tickets with related pcap file in those cases.
I'm not sure about the qcdiag ones, I never used it so far. It would be great if someone had some sample pcap at hand.
Assigning to you for feedback, feel free to re-assign to me if you want me to (either 1, 2 or both):
1- spend time on getting some qcdiag samples somehow
2- Make sure those pcap files are displayed correctly in wireshark
Updated by laforge about 3 years ago
On Mon, Feb 08, 2021 at 02:46:50PM +0000, pespin [REDMINE] wrote:
I'm not sure about the qcdiag ones, I never used it so far. It would be great if someone had some sample pcap at hand.
Hoernchen should be able to help you with that, as he worked on this topic for a customer some months ago.
Assigning to you for feedback, feel free to re-assign to me if you want me to (either 1, 2 or both):
1- spend time on getting some qcdiag samples somehow
2- Make sure those pcap files are displayed correctly in wireshark
Assigning to Hoernchen for coughing up a pcap sample, who can then re-assign to you once
the file is attached.
Updated by laforge about 3 years ago
- Status changed from New to Feedback
- Assignee changed from laforge to Hoernchen