Project

General

Profile

Bug #1995

Segfault when callin osmo_sccp_tx_unitdata() without being connected

Added by dexter over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
-
Start date:
04/07/2017
Due date:
% Done:

100%

Spec Reference:

Description

The problem occurs when a peer (server role) tries to send unitdata to a remote peer (client) that is not connected.

The attached code contains the source code snippets I used for experimentation.

Good case:
fist start dummy_msc (client), then dummy_bsc (server). The client will connect and when the timer at the server expires unitdata is sent from the server to the client.

Bad case:
start dummy_bsc, when the timer expires, the segfault occurs.

Note: The scheme is a bit odd and not covered by the examples, since there, the server never actively sends data without being stimulated through an existing connection. It is questionable if a server should send unsolicited data at all. In this test, the server role has been chosen for one side because of the lack of an STP.

good_case_dummy_msc.log good_case_dummy_msc.log 8.12 KB dexter, 04/07/2017 08:31 AM
good_case_dummy_bsc.log good_case_dummy_bsc.log 7.53 KB dexter, 04/07/2017 08:31 AM
bad_case_dummy_bsc.log bad_case_dummy_bsc.log 2 KB dexter, 04/07/2017 08:31 AM
dummy_msc.tar dummy_msc.tar 50 KB dexter, 04/07/2017 08:31 AM
dummy_bsc.tar dummy_bsc.tar 60 KB dexter, 04/07/2017 08:31 AM
0001-osmo_ss7-Fix-segfault-when-routing-MTP-TRANSFER.req-.patch 0001-osmo_ss7-Fix-segfault-when-routing-MTP-TRANSFER.req-.patch 1.16 KB laforge, 04/07/2017 05:22 PM

History

#1 Updated by laforge over 2 years ago

please see attached patch, it fixes the issue.

#2 Updated by laforge over 2 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 80 to 100

has been merged to master.

#3 Updated by laforge over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)