Cellular Network Infrastructure » OsmoGSMTester

This should be solved by https://gerrit.osmocom.org/2486 and https://gerrit.osmocom.org/2485

I often use ctrl-c abort a test gracefully. Pau, do you still have a usage where that doesn't work?

Yes, I still see the issue with latest master when I'm running the test (ie. nitb started). Then I CTRL+C and the resources are not freed/stopped:

# ps -ef | grep osmo
root     28959 28957 31 12:42 ?        00:00:20 python3 -u ./osmo-gsm-tester.py /var/tmp/osmo-gsm-tester/trials//trial-100 -s sms
root     28974 28959  0 12:42 ?        00:00:00 tcpdump -n -i eth1 -w /var/tmp/osmo-gsm-tester/trials/trial-100/run.2017-05-17_12-42-22/osmo-nitb_10.42.42.1/pcap/pcap-recorder_eth1.pcap host 10.42.42.1 and port not 22
root     28975 28959  0 12:42 ?        00:00:00 /var/tmp/osmo-gsm-tester/trials/trial-100/inst/osmo-nitb/bin/osmo-nitb -c /var/tmp/osmo-gsm-tester/trials/trial-100/run.2017-05-17_12-42-22/osmo-nitb_10.42.42.1/osmo-nitb.cfg
root     29051 28959  0 12:42 ?        00:00:00 ssh root@10.42.42.114 cd "/osmo-gsm-tester/osmo-bts-sysmo"; LD_LIBRARY_PATH=/osmo-gsm-tester/osmo-bts-sysmo/lib /osmo-gsm-tester/osmo-bts-sysmo/bin/osmo-bts-sysmo -c /osmo-gsm-tester/osmo-bts-sysmo.cfg -r 1 -i 10.42.42.1

Here's a better example. I see osmo-gsm-tester + subprocesses. I kill osmo-gsm-tester. Subprocesses are still alive afterwards:

root@osmo-gsm-tester-rnd:~# ps -ef | grep osmo
root     29466 29464 28 12:50 ?        00:00:22 python3 -u ./osmo-gsm-tester.py /var/tmp/osmo-gsm-tester/trials//trial-100 -s sms
root     29480 29466  0 12:50 ?        00:00:00 tcpdump -n -i eth1 -w /var/tmp/osmo-gsm-tester/trials/trial-100/run.2017-05-17_12-50-48/osmo-nitb_10.42.42.1/pcap/pcap-recorder_eth1.pcap host 10.42.42.1 and port not 22
root     29481 29466  0 12:50 ?        00:00:00 /var/tmp/osmo-gsm-tester/trials/trial-100/inst/osmo-nitb/bin/osmo-nitb -c /var/tmp/osmo-gsm-tester/trials/trial-100/run.2017-05-17_12-50-48/osmo-nitb_10.42.42.1/osmo-nitb.cfg
root     29490 29466  0 12:51 ?        00:00:00 ssh root@10.42.42.114 cd "/osmo-gsm-tester/osmo-bts-sysmo"; LD_LIBRARY_PATH=/osmo-gsm-tester/osmo-bts-sysmo/lib /osmo-gsm-tester/osmo-bts-sysmo/bin/osmo-bts-sysmo -c /osmo-gsm-tester/osmo-bts-sysmo.cfg -r 1 -i 10.42.42.1
root     29531 20325  0 12:52 pts/0    00:00:00 grep osmo

root@osmo-gsm-tester-rnd:~# kill 29466

root@osmo-gsm-tester-rnd:~# ps -ef | grep osmo
root     29480     1  0 12:50 ?        00:00:00 tcpdump -n -i eth1 -w /var/tmp/osmo-gsm-tester/trials/trial-100/run.2017-05-17_12-50-48/osmo-nitb_10.42.42.1/pcap/pcap-recorder_eth1.pcap host 10.42.42.1 and port not 22
root     29481     1  0 12:50 ?        00:00:00 /var/tmp/osmo-gsm-tester/trials/trial-100/inst/osmo-nitb/bin/osmo-nitb -c /var/tmp/osmo-gsm-tester/trials/trial-100/run.2017-05-17_12-50-48/osmo-nitb_10.42.42.1/osmo-nitb.cfg
root     29490     1  0 12:51 ?        00:00:00 ssh root@10.42.42.114 cd "/osmo-gsm-tester/osmo-bts-sysmo"; LD_LIBRARY_PATH=/osmo-gsm-tester/osmo-bts-sysmo/lib /osmo-gsm-tester/osmo-bts-sysmo/bin/osmo-bts-sysmo -c /osmo-gsm-tester/osmo-bts-sysmo.cfg -r 1 -i 10.42.42.1

Patch available here for review: https://gerrit.osmocom.org/#/c/2670/2

though I will / did do the patch review, getting a patch through review is still your task and technically could be done by anyone. So IMHO this should remain assigned to and be resolved by you.