unify sccp instance configuration
The configuration of the sccp instance can be unified. The parameters of osmo_sccp_simple_client() which is used to create the sccp instance could be configured using the built in VTY of libosmo-sccp. This would unify the configuration of SCCP and offload the application specific VTY. It also would help to simplify the configuration from the users perspective. The user will not have to learn a new way to configur SS7 applications all the time.
struct osmo_sccp_instance * osmo_sccp_simple_client(void *ctx, const char *name, uint32_t pc, enum osmo_ss7_asp_protocol prot, int local_port, const char *local_ip, int remote_port, const char *remote_ip);
- % Done changed from 10 to 70
The simple client is now fully configurable via VTY, while the basic idea here is to use the VTY configuration whenever it is available. If no configuration is detected, the caller provided parameters are used. The patch can be found here: https://gerrit.osmocom.org/#/c/3303/
However, there is still room for improvement. Since it does not make much sense to set routes on a client application we should try to hide this functionality from the user. At the moment setting a default route is only necessary when an AS/ASP configuration is set by the user via VTY. If it is left out, there is no problem. AS/ASP will be created automatically. If the user saves the VTY config, the result will be a valid config with AS, ASP and default route. This can be confusing, so making a good selection of VTY commands and disabling the commands that only make sense in an STP application would be the next step here.
- Status changed from In Progress to Stalled
Its probably best to close this and do the next steps with a separate tasks. But should keep it open that we do not forget about it.
The next step would be to select and lock down the commands which are not needed in a client application.
- % Done changed from 70 to 80
- We now create the default route for ASP applications automatically, also the VTY command for creating routes is locked down in ASP mode, so there should be no longer confusion about this
- Doxygen comments for simple client are added
- PC of the CS7 instance is checked. If it is invalid. The default setting will be used.