Project

General

Profile

Bug #2521

reduce levels in struct mgcp_conn_rtp

Added by dexter 9 months ago. Updated about 1 month ago.

Status:
New
Priority:
Low
Assignee:
Category:
-
Target version:
-
Start date:
09/25/2017
Due date:
% Done:

0%

Estimated time:

Description

See struct mgcp_conn_rtp in mgcp_internal.h. Struct member struct mgcp_rtp_end end could be eliminated by putting all struct members from struct mgcp_rtp_end to struct mgcp_conn_rtp. This would reduce one level when dereferencing the pointers. The code would become more readable.

History

#1 Updated by laforge 8 months ago

#2 Updated by laforge 7 months ago

  • Priority changed from Normal to Low

#3 Updated by dexter about 1 month ago

I had another look into this, but I see a problem. If we merge the structs we would also have to merge a lot more since struct mgcp_conn_rtp acts as an umbrellla for a lot of structs.

For example there is still:
struct mgcp_rtp_state state;
struct mgcp_rtp_tap tap_in;
struct mgcp_rtp_tap tap_out;

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)