Bug #2543
closedofono: call removed+added during transition dialing->alerting
100%
Description
/sierra_1: Manufacturer: 'Sierra Wireless, Incorporated', Model: 'MC7304', Revision: 'SWI9X15C_06
.03.32.04 r28324 CNSHZ-AR-BUILD 2015/05/25 01:09:15', Serial: '356853054230919'
/sierra_2: Manufacturer: 'Sierra Wireless, Incorporated', Model: 'MC7304', Revision: 'SWI9X15C_06
.03.32.04 r28324 CNSHZ-AR-BUILD 2015/05/25 01:09:15', Serial: '356853052645654'
14:11:44.255665 tst /sierra_1: dialing: 10800 14:11:44.598970 tst /sierra_1: DBG: Adding /sierra_1/voicecall01 to call list 14:11:44.622919 tst /sierra_1: DBG: 'org.ofono.VoiceCallManager'.CallAdded() -> /sierra_1/voicecall01="{'Emergency': False, 'Multiparty': False, 'S tate': 'dialing', 'LineIdentification': '10800', 'RemoteHeld': False, 'Name': '', 'RemoteMultiparty': False}" 14:11:44.644959 tst /sierra_1: Call already exists! 14:11:44.666440 tst /sierra_1: DBG: call_id_list: ['/sierra_1/voicecall01'] 14:11:44.688675 tst /sierra_1: DBG: 'org.ofono.VoiceCallManager'.CallRemoved() -> /sierra_1/voicecall01 14:11:44.711983 tst /sierra_2: DBG: call_id_list: [] 14:11:45.739488 tst /sierra_2: DBG: call_id_list: [] 14:11:46.766681 tst /sierra_2: DBG: call_id_list: [] 14:11:47.795849 tst /sierra_1: DBG: 'org.ofono.VoiceCallManager'.CallAdded() -> /sierra_1/voicecall01="{'Emergency': False, 'Multiparty': False, 'S tate': 'alerting', 'LineIdentification': '10800', 'RemoteHeld': False, 'Name': '', 'RemoteMultiparty': False}" 14:11:47.821581 tst /sierra_2: DBG: call_id_list: [] 14:11:48.853007 tst /sierra_2: DBG: call_id_list: [] 14:11:49.878372 tst /sierra_2: DBG: 'org.ofono.VoiceCallManager'.CallAdded() -> /sierra_2/voicecall01="{'Emergency': False, 'Multiparty': False, 'S tate': 'dialing', 'LineIdentification': '10799', 'RemoteHeld': False, 'Name': '', 'RemoteMultiparty': False}" 14:11:49.901843 tst /sierra_2: DBG: call_id_list: ['/sierra_2/voicecall01'] 14:11:49.919629 tst /sierra_2: DBG: call_id_list: ['/sierra_2/voicecall01'] 14:11:49.938255 tst /sierra_2: Answer call /sierra_2/voicecall01
During Dial() from /sierra_1 to /sierra_2, when call changes state from "dialing" to "alerting", the signals CallRemoved + CallAdded are called. Instead, only a PropertyChanged() signal should be signaled.
Related issues
Updated by pespin over 6 years ago
- Related to Bug #2240: ofono: voice calls are not implemented for any modem added
Updated by pespin over 6 years ago
- Related to Bug #2549: ofono: Race condition / failure answering call added
Updated by pespin over 6 years ago
The PropertyChanged() signal is actually for the VoiceCall object and not the VoiceCallManager one, and I'm not listening for signals on the former, so it could be working properly. Still the Removed+Added should not happen.
Updated by pespin over 6 years ago
This is the timeline of received signalsfrom ofono using "msbus2 -l -s org.ofono":
[SIGNAL] org.ofono.VoiceCallManager.CallAdded /sierra_1 :1.26 ('/sierra_1/voicecall01', {'State': <'dialing'>, 'LineIdentification': <'10834'>, 'Name': <''>, 'Multiparty': <false>, 'RemoteHeld': < false>, 'RemoteMultiparty': <false>, 'Emergency': <false>}) [SIGNAL] org.ofono.VoiceCall.PropertyChanged /sierra_1/voicecall01 :1.26 ('LineIdentification', <''>) [SIGNAL] org.ofono.VoiceCall.PropertyChanged /sierra_1/voicecall01 :1.26 ('IncomingLine', <'10834'>) [SIGNAL] org.ofono.VoiceCall.PropertyChanged /sierra_1/voicecall01 :1.26 ('LineIdentification', <'10834'>) [SIGNAL] org.ofono.VoiceCall.PropertyChanged /sierra_1/voicecall01 :1.26 ('IncomingLine', <''>) [SIGNAL] org.ofono.VoiceCall.PropertyChanged /sierra_1/voicecall01 :1.26 ('State', <'disconnected'>) [SIGNAL] org.ofono.VoiceCallManager.CallRemoved /sierra_1 :1.26 ('/sierra_1/voicecall01',) [SIGNAL] org.ofono.VoiceCallManager.CallAdded /sierra_1 :1.26 ('/sierra_1/voicecall01', {'State': <'alerting'>, 'LineIdentification': <'10834'>, 'Name': <''>, 'Multiparty': <false>, 'RemoteHeld': <false>, 'RemoteMultiparty': <false>, 'Emergency': <false>})
Updated by lynxis over 6 years ago
- Status changed from In Progress to Feedback
- Assignee changed from lynxis to pespin
- % Done changed from 0 to 100
merged into osmo-gsm-tester and deployed on rnd and production setup.
https://git.sysmocom.de/ofono/commit/?h=osmo-gsm-tester&id=828eec5e97185dfd9c02b932d7dea4bcdea330c9
Updated by pespin over 6 years ago
- Status changed from Feedback to Resolved
I tested it in RnD and it's fixed.