Bug #2967
closedensure that all programs using osmo_fsm call osmo_fsm_vty_add_cmds()
0%
Description
Some programs, for instance osmo-msc, currently do not call osmo_fsm_vty_add_cmds() and thus lack the corresponding commands in the VTY.
All programs using osmo_fsm should call this function. Also consider the possibility to make this happen automatically (e.g. directly in libosmocore).
Updated by stsp about 6 years ago
- Status changed from New to In Progress
Patch for osmo-msc proposed in https://gerrit.osmocom.org/#/c/6841/
Updated by stsp about 6 years ago
There does not seem to be any osmo_fsm user (apart from osmo-msc) which does not initialize osmo_fsm vty commands.
The current users are: osmo-bsc, libosmo-sccp, osmo-msc
$ find . -name '*.c' -exec grep -H -e core/fsm.h -e osmo_fsm_vty_add_cmds {} \; ./osmo-bsc/src/osmo-bsc/osmo_bsc_reset.c:#include <osmocom/core/fsm.h> ./osmo-bsc/src/osmo-bsc/osmo_bsc_mgcp.c:#include <osmocom/core/fsm.h> ./osmo-bsc/src/libbsc/bsc_vty.c: osmo_fsm_vty_add_cmds(); ./osmo-bsc/src/libbsc/a_reset.c:#include <osmocom/core/fsm.h> ./osmo-bsc/src/libbsc/abis_om2000.c:#include <osmocom/core/fsm.h> ./osmo-bts/src/common/msg_utils.c:#include <osmocom/core/fsm.h> ./osmo-msc/src/libcommon-cs/a_reset.c:#include <osmocom/core/fsm.h> ./osmo-msc/src/libmsc/subscr_conn.c:#include <osmocom/core/fsm.h> ./osmo-msc/src/libmsc/msc_mgcp.c:#include <osmocom/core/fsm.h> ./osmo-msc/src/libvlr/vlr_lu_fsm.c:#include <osmocom/core/fsm.h> ./osmo-msc/src/libvlr/vlr_access_req_fsm.c:#include <osmocom/core/fsm.h> ./osmo-msc/src/libvlr/vlr.c:#include <osmocom/core/fsm.h> ./osmo-msc/src/libvlr/vlr_auth_fsm.c:#include <osmocom/core/fsm.h> ./libosmo-sccp/src/sccp_sclc.c:#include <osmocom/core/fsm.h> ./libosmo-sccp/src/xua_asp_fsm.c:#include <osmocom/core/fsm.h> ./libosmo-sccp/src/sccp_scoc.c:#include <osmocom/core/fsm.h> ./libosmo-sccp/src/xua_as_fsm.c:#include <osmocom/core/fsm.h> ./libosmo-sccp/src/sua.c:#include <osmocom/core/fsm.h> ./libosmo-sccp/src/xua_default_lm_fsm.c:#include <osmocom/core/fsm.h> ./libosmo-sccp/examples/m3ua_example.c:#include <osmocom/core/fsm.h> ./libosmo-sccp/stp/stp_main.c:#include <osmocom/core/fsm.h> ./libosmo-sccp/stp/stp_main.c: osmo_fsm_vty_add_cmds(); ./libosmocore/tests/fsm/fsm_test.c:#include <osmocom/core/fsm.h> ./libosmocore/src/fsm.c:#include <osmocom/core/fsm.h> ./libosmocore/src/ctrl/fsm_ctrl_commands.c:#include <osmocom/core/fsm.h> ./libosmocore/src/vty/fsm_vty.c:#include <osmocom/core/fsm.h> ./libosmocore/src/vty/fsm_vty.c: * command during startup: \ref osmo_fsm_vty_add_cmds ./libosmocore/src/vty/fsm_vty.c:void osmo_fsm_vty_add_cmds(void)
Updated by stsp about 6 years ago
Philipp pointed out there's another caller. My git repositories weren't current :-/
https://gerrit.osmocom.org/#/c/6842/
I am also starting to look into installing these commands automatically from libosmocore: https://gerrit.osmocom.org/#/c/6843/
Updated by stsp about 6 years ago
- Status changed from In Progress to Resolved
Above change has been merged. No other programs missing a call to osmo_fsm_vty_add_cmds() are known.