Project

General

Profile

Actions

Bug #3044

closed

Invalid option '-f' in systemd unit file

Added by jbruckner about 6 years ago. Updated about 6 years ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
-
Target version:
-
Start date:
03/08/2018
Due date:
% Done:

0%

Spec Reference:

Description

The osmo-ggsn.service file [1] contains the '-f' switch, which is not a valid option (anymore?).

[1] https://osmocom.org/projects/openggsn/repository/revisions/master/entry/contrib/osmo-ggsn.service

Actions #1

Updated by laforge about 6 years ago

  • Assignee set to stsp
  • Priority changed from Low to High
Actions #2

Updated by stsp about 6 years ago

In dda21ed7d4a897c9284c69175d0da598598eae40 from August 2017, osmo-ggsn getopt parsing was changed from a
custom command line parser (called "cmdline_parser") to standard getopt. The old parser supported the
--fg option ("run in foreground"), and -f was an alias for --fg.
In the same commit a new '--daemonize' option was introduced which enables background execution and defaults to off.

So the former behaviour with -f is now the default behaviour.
It looks like commit dda21ed7d4a897c9284c69175d0da598598eae40 simply overlooked the systemd config file.

Actions #3

Updated by stsp about 6 years ago

Patch in https://gerrit.osmocom.org/#/c/7402/ removes the -f flag.

Actions #4

Updated by stsp about 6 years ago

  • Status changed from New to In Progress
Actions #5

Updated by stsp about 6 years ago

  • Status changed from In Progress to Resolved

Above change has been merged.

Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)