Project

General

Profile

Bug #3112

Clean up / fix osmo_bsc_filter.c

Added by dexter over 1 year ago. Updated 5 months ago.

Status:
Resolved
Priority:
Low
Assignee:
Category:
-
Target version:
-
Start date:
03/26/2018
Due date:
% Done:

100%

Spec Reference:
Tags:

Description

There are some leftovers from the time where osmo-bsc had an SCCPLITE/IPA based A interface. There is still an msc_con->is_connected and an msc_con->is_authenticated flag which is hard coded to 1. These flags are used by osmo_bsc_filter. Presumably the functionality in osmo_bsc_filter is presumably broken. We need to look into this and either fix it or remove it.

See also osmo_bsc_msc.c
data->msc_con->is_connected = 1;
data->msc_con->is_authenticated = 1;

History

#1 Updated by laforge over 1 year ago

  • Priority changed from Normal to Low

#2 Updated by laforge over 1 year ago

  • Tags set to SCCPlite

#3 Updated by dexter 5 months ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

I have checked back on the status of osmo_bsc_filter.c. It is already cleaned up.

The struct member data->msc_con->is_authenticated = 1 is already there. I have removed it now:

https://gerrit.osmocom.org/c/osmo-bsc/+/15007 bsc_msc_data: remove unused member is_authenticated

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)