Project

General

Profile

Actions

Feature #3203

closed

have jenkins build verification job

Added by laforge almost 6 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
Start date:
04/23/2018
Due date:
% Done:

100%

Spec Reference:

Description

... right now all our build verification jobs are autotools based. We need to see how we can deal with cmake here, particularly if we want to build with -Werror and/or enable -fsanitize.

Actions #1

Updated by laforge over 5 years ago

  • Assignee set to osmith
Actions #2

Updated by laforge over 4 years ago

  • Priority changed from Low to Normal
Actions #3

Updated by osmith over 4 years ago

Status: In Progress
Done: 90%

Patches submitted:

steve-m: can you review/merge the osmo-fl2k patch?

EDIT: build ran fine with Werror, so I've enabled it in jenkins.sh.

Actions #4

Updated by osmith over 4 years ago

  • Status changed from New to Stalled

Waiting for steve-m to review/merge the osmo-fl2k.git patch. Afterwards I can update the osmo-ci.git patch, so it does not conflict anymore. Setting to stalled.

Actions #5

Updated by osmith over 4 years ago

  • % Done changed from 0 to 90
Actions #6

Updated by steve-m over 4 years ago

osmith wrote:

Waiting for steve-m to review/merge the osmo-fl2k.git patch. Afterwards I can update the osmo-ci.git patch, so it does not conflict anymore. Setting to stalled.

Sorry, I was not aware of the patch in Gerrit. Will merge it later today.

Actions #7

Updated by steve-m over 4 years ago

I just took a look, and your patch was already merged back in August:
https://cgit.osmocom.org/osmo-fl2k/commit/?id=fb206158f9ba8b426ca7c8fb180f4fc324ff208a

Actions #8

Updated by laforge over 4 years ago

  • Status changed from Stalled to In Progress
  • Assignee changed from osmith to laforge

I just rebased the osmo-ci patch and merged it.

Actions #9

Updated by laforge over 4 years ago

  • Assignee changed from laforge to osmith

for some strange reason cmake cannot be found, despite all slaves having been updated with the new build container? Re-assigning to osmith.

Actions #10

Updated by osmith over 4 years ago

I did not realize that the patch was already merged - thanks, Steve!

The osmo-ci.git patch had the old docker image hardcoded, that's why it could not find cmake. Fix in: https://gerrit.osmocom.org/c/osmo-ci/+/16399

Notably the script is really fast:

Took 3.4 sec on build2-deb9build-ansible

Actions #11

Updated by osmith over 4 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 90 to 100
Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)