Project

General

Profile

Actions

Feature #3452

closed

name binaries including their git version number

Added by laforge over 5 years ago. Updated almost 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
firmware
Target version:
-
Start date:
08/07/2018
Due date:
% Done:

100%

Spec Reference:

Description

At http://ftp.osmocom.org/binaries/simtrace2/firmware/ we now have published binaries, which is nice. However, it would be even nicer if they included the git version in their name, something like simtrace-cardem-dfu-0.2.1-abcdef.bin with simtrace-cardem-dfu.bin being a symlink to that.

This has generaly proven good practise in other projects.

It may be easiest to actually adjust he makefile of simtrace2.git to generate the files + symlinks like that, and then simply rsync those over to the ftp.

Actions #1

Updated by laforge over 5 years ago

  • Category set to firmware
Actions #2

Updated by demodulate over 5 years ago

A simple modification for the combined target:

diff --git a/firmware/Makefile b/firmware/Makefile
index ca22bdd..7a8221c 100644
--- a/firmware/Makefile
+++ b/firmware/Makefile
@@ -183,6 +183,9 @@ OUTPUT := $(BIN)/$(OUTPUT)
 all: apps/$(APP)/usb_strings_generated.h $(BIN) $(OBJ) $(MEMORIES)

 combined: $(OUTPUT)-combined.bin
+       mv $(OUTPUT)-combined.bin $(OUTPUT)-combined-$(GIT_VERSION).bin
+       ln -s $(BOARD)-$(APP)-combined-$(GIT_VERSION).bin $(OUTPUT)-combined.bin
+

 $(BIN)/$(BOARD)-dfu-flash-padded.bin: $(BIN)/$(BOARD)-dfu-flash.bin
        dd if=/dev/zero bs=16384 count=1 of=$@

Actions #3

Updated by laforge almost 5 years ago

  • Status changed from New to In Progress
  • Assignee changed from tsaitgaist to laforge
Actions #4

Updated by laforge almost 5 years ago

  • % Done changed from 0 to 80
Actions #5

Updated by laforge almost 5 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 80 to 100

patch was merged (not only for simtrace2 firmware), version-named builds are available from https://ftp.osmocom.org/binaries/simtrace2/firmware/

Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)