Project

General

Profile

Bug #3805

OsmoMSC sends invalid BSSMAP length field on CSFB CLEAR COMMAND

Added by laforge 28 days ago. Updated 28 days ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
A interface (general)
Target version:
-
Start date:
02/18/2019
Due date:
% Done:

100%

Resolution:

Description

When sending a BSSMAP CLEAR COMMAND with CSFB indicator, osmo-msc currently sends '0004200401098' where '04' is the length of the BSSMAP message which we follow with 5 bytes of IEs :(

Let's not only fix that one encoding bug but also add a general consistency checker in the BSSAP output path to ensure we catch sending invalid length fields inside osmo-msc (and osmo-bsc) itself.

See also: https://www.eclipse.org/forums/index.php/t/1097647/


Related issues

Related to OsmoMSC - Feature #3778: Support CSFB "Fast Return"Resolved2019-02-03

Related to OsmoBSC - Bug #3806: OsmoBSC accepts BSSAP with wrong length fieldNew2019-02-18

History

#1 Updated by laforge 28 days ago

#2 Updated by laforge 28 days ago

  • Status changed from New to In Progress

#3 Updated by laforge 28 days ago

  • % Done changed from 0 to 80

Actual encoding bug adressed in https://gerrit.osmocom.org/#/c/libosmocore/+/12924/

The bug only came about because
  1. the related function gsm0808_create_clear_command2() was introduced without any unit test coverage.
  2. the feature in osmo-msc was developed / added before having a TTCN-3 testcase in place

It saddens me a bit that >= 1.5 years after introducing test-driven development we still see those kind of issues slipping into master. We need to work together to improve our processes. This doesn't only affect the developer, but also the reviewers. We should have spotted the missing unit test during review.

#4 Updated by laforge 28 days ago

  • Status changed from In Progress to Resolved
  • % Done changed from 80 to 100

libosmocore patch merged, OsmoMSC now sends correct length values.

#5 Updated by laforge 28 days ago

  • Related to Bug #3806: OsmoBSC accepts BSSAP with wrong length field added

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)