master-simtrace2 failed to build from October 19 onwards: $WORKSPACE environment missing
When we write a "contrib/jenkins.sh" job, we assume that all the jenkins environment variables as documented at https://wiki.jenkins.io/display/JENKINS/Building+a+software+project are available to the script. In the specific case, $WORKSPACE was used, which failed after the job had been moved inside docker.
- https://jenkins.osmocom.org/jenkins/job/master-simtrace2/a1=default,a2=default,a3=default,a4=default,label=osmocom-master-debian9/540/console is the last working log
- https://jenkins.osmocom.org/jenkins/job/master-simtrace2/a1=default,a2=default,a3=default,a4=default,label=osmocom-master-debian9/541/console is the first failing job.
I think it's generally a good idea to make sure all the jenkins environment variables as described at the link above are passed into the docker container, so authors of contrib/jenkins.sh don't have to consider undocumented osmocom-docker-specific restrictions but can use the normal set of environment variables..
For $WORKSPACE, it's questionable what to do. Probably best we mount it into the docker container, and then specify that mount point as "-e WORKSPACE"?