Project

General

Profile

Actions

Bug #4278

closed

remsim-bankd doesn't recover after remsim-server restart

Added by laforge over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
remsim-bankd
Target version:
-
Start date:
11/22/2019
Due date:
% Done:

50%

Spec Reference:

Description

I've found this while executing the test suite: remsim-bankd refuses to install a mapping if there is already an existing mapping for that slot. While this makes sense in theory, in practise this means that if the remsim-server looses state (e.g. restart), the old maps in bankd will still exist, and new maps cannot be installed.

I guess we either have to permit new slotmaps to overwrite old ones, or we have to introduce a command by which a [restarting] remsim-server can reset the logical state at a bankd.

The remsim-server could then send that related reset command after a restart. However, this would mean all existing mappings are deleted and re-added, which will break all client-bankd connections happening at the time. So the better approach is probabl to simply overwrite any existing mapping. If the new mapping is identical with the old mapping, we can keep the existing client-bankd communication and the server restart has no implication on any ongoing SIM card communication. Only if the new mapping is different, we'd terminate the connection to the client and replace the old map with the new one.

Actions #1

Updated by laforge over 4 years ago

  • % Done changed from 0 to 10

This is also what makes RemsimBankd_Tests.TC_createMapping_busy fail in the automatic test suite execution. It passes if only this test is executed, but it fails if it's executed after others, as they leave state (maps) in bankd.

Actions #2

Updated by laforge over 4 years ago

same applies for TC_createMapping_clientConnect

Actions #3

Updated by laforge over 4 years ago

  • Status changed from New to In Progress
Actions #5

Updated by laforge over 4 years ago

  • % Done changed from 10 to 50
Actions #6

Updated by laforge over 4 years ago

  • Status changed from In Progress to Resolved

Patches and tests merged

Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)