Project

General

Profile

Bug #4348

investigate / resolve memleaks in mtp_user_prim_cb()

Added by neels 20 days ago. Updated 19 days ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
Start date:
01/08/2020
Due date:
% Done:

100%

Spec Reference:

Description

An apparently half-finished patch https://gerrit.osmocom.org/c/libosmo-sccp/+/9957
was merged and then reverted because it didn't pass ttcn tests.
Take a closer look at free / memleak issues in that code path and fix properly.

History

#1 Updated by neels 20 days ago

possibly related: https://gerrit.osmocom.org/c/libosmo-sccp/+/10443 (a patch that was merged after the one mentioned above was written)

#2 Updated by pespin 20 days ago

  • Assignee set to pespin

So it's clear your patch is not correct with current code base. Mine I think was fixing the memleak fine but it was introducing a double-free on other code paths. I submitted a fix for that:
https://gerrit.osmocom.org/c/libosmo-sccp/+/16771 sua.c: Avoid double free in sua_rx_msg()->...->mtp_user_prim_cb()

#3 Updated by pespin 19 days ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Merged, closing.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)