Project

General

Profile

Bug #4667

mgcp_client_fsm 'terminate' logic has no timeout

Added by laforge 19 days ago.

Status:
New
Priority:
Normal
Assignee:
Target version:
-
Start date:
07/15/2020
Due date:
% Done:

0%

Spec Reference:

Description

While reading the mgcp_client_fsm code I noticed the 'terminate' logic whihc delays sending a DLCX if some other operation is still pending.

I don't really understand why this is required (it's perfectly legal to send MGCP commands without waiting for the response first, right?) - the problem is that there appears to be no related timeout. So if we set that 'terminate' flag, and we never get a response to whatver previous MGCP ommand, then we are stuck in this state indefinitiely and we never send the DLCX.

The main point of osmo_fsm was to introduce mechanisms to avoid such 'stuck' situations and to ensure there always is a timer running to recover.

Maybe my reading of the code os wrong, please clarify.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)