Project

General

Profile

Bug #4855

ns2: Better formatting for show ns

Added by daniel 11 months ago. Updated 14 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
libosmogb
Target version:
-
Start date:
11/06/2020
Due date:
% Done:

100%

Spec Reference:

Description

The current formatting when running show ns looks rather weird and confusing:

OsmoGbProxy# show ns 
UDP bind: 127.0.0.100:23000 dcsp: 0
  1 NS-VC: 
    udp)[127.0.0.100]:23000<101>[192.168.100.239]:7777
NSEI   101
:47808 <> 192.168.100.239:7777Remote: udp)[127.0.0.100]:23000<101>[192.168.100.239]:7777 UDP


Checklist

  • Implement gprs_ns2_ll_str_buf for FR_GRE

Related issues

Related to libosmocore - Bug #4797: vty: the output of 'show ns' command is confusingFeedback10/10/2020

History

#1 Updated by daniel 11 months ago

  • % Done changed from 0 to 20

With https://gerrit.osmocom.org/c/libosmocore/+/21062 the output looks better already:

OsmoGbProxy# show ns 
UDP bind: 127.0.0.100:23000 dcsp: 0
  1 NS-VC: 
    udp)[127.0.0.100]:23000<101>[192.168.100.239]:7777
NSEI   101
 udp)[127.0.0.100]:23000<101>[192.168.100.239]:7777

We still print the nsvc twice - once in dump_bind and once in dump_nse. dump_bind doesn't seem to be implemented for every bind, though and the ns2_ll_str function is quite incomplete when dealing with non-udp nsvc.

#2 Updated by daniel 11 months ago

  • Checklist item Implement gprs_ns2_ll_str_buf for FR_GRE added
  • Checklist item Implement gprs_ns2_ll_str_buf for E1 added
  • Status changed from In Progress to New

lynxis: What do you think, should we just print the NSVC in dump_nse and not in dump_bind?

#3 Updated by laforge 10 months ago

  • Category set to libosmogb

#4 Updated by lynxis 10 months ago

lynxis: What do you think, should we just print the NSVC in dump_nse and not in dump_bind?

good idea.

Maybe have a different command to `show ns binds`

#5 Updated by laforge 6 months ago

I think lynxis merged some related patches recently?

#6 Updated by laforge 6 months ago

  • Related to Bug #4797: vty: the output of 'show ns' command is confusing added

#7 Updated by lynxis 14 days ago

  • Checklist item Implement gprs_ns2_ll_str_buf for FR_GRE set to Done

#8 Updated by lynxis 14 days ago

  • Checklist item deleted (Implement gprs_ns2_ll_str_buf for E1)

#9 Updated by lynxis 14 days ago

  • Status changed from New to Closed
  • Assignee changed from daniel to lynxis
  • % Done changed from 20 to 100

The `show ns` has been improved and gprs_ns2_ll_str() has been implemented for the other link layers.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)