Project

General

Profile

Bug #4911

overriding PATH in 'docker run' is a bad idea

Added by laforge about 1 month ago. Updated 8 days ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
Start date:
12/17/2020
Due date:
% Done:

100%

Spec Reference:

Description

In the "docker run" command of our master and gerrit builds, we are overriding the PATH when executing the contaienr.

This is wrong in various ways:
  • the container build process will make sure that everything installed is in path (e.g. special toolchains in /opt, ...) which we then loose
  • we actually expand $PATH on the host, outside the container, and then use it inside the container. Those two have no relation at all.

We only appear to be doing so to get the scripts from osmo-build.sh into PATH, and we do that by a hack of mounting the host volume to /build_bin

I would think the proper solution here is to simply make sure that the container image itself (debian-stretch-jekins) has those scripts in /usr/local/bin when creating the image?

If we do this, we can stop overriding PATH, which also means that the docker_run command for both osmo-e1-hardware and the default one from the template cna be re-unified.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)