Project

General

Profile

Feature #4992

Split osmo-gbproxy from osmo-sgsn into own git repository

Added by osmith about 1 month ago. Updated 27 days ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
Start date:
01/29/2021
Due date:
% Done:

100%

Spec Reference:

Description

As discussed, we want to split osmo-gbproxy into its own git repository.

I'll append a checklist to this issue shortly.


Checklist

  • run git filter-branch (move src/gbproxy/* to src/*, remove history of all includes but gb_proxy.h)
  • create repository in gerrit
  • push to repository on gerrit (version after git filter-branch, doesn't build yet; further changes are in osmith/wip)
  • add osmo-gbproxy to git.osmocom.org (sync from gerrit)
  • adjust configure.ac, Makefile.am files to make it build again, add vty.h, debug.h in src/
  • adjust debian packaging
  • verify that osmo-gbproxy builds for debian10 on obs, and tweak it until it does work
  • adjust rpm spec file
  • push fixes for build system and packaging to master
  • verify that OBS can build the rpm spec file
  • remove osmo-gbproxy from osmo-sgsn.git (do this before building osmo-gbproxy deb in official nightly OBS, otherwise we'll have conflicts when installing both)
  • add osmo-gbproxy to osmo-ci.git master-builds / gerrit verification
  • enable osmo-gbproxy in osmo-ci.git OBS scripts for nightly
  • debian: fix building manuals
  • remove unrelated manuals
  • fix VTY tests
  • adjust docker containers for ttcn-3 tests (thanks, Daniel)
  • roll out: merge "OBS nightly: add osmo-gbproxy: https://gerrit.osmocom.org/c/osmo-ci/+/22603
  • roll out: merge "Add osmo-gbproxy-* container for osmo-gbproxy": https://gerrit.osmocom.org/c/docker-playground/+/22636
  • roll out: wait until OBS nightly has built gbproxy packages
  • roll out: successful ttcn3 test run at jenkins with split package
  • roll out: merge "gbproxy: remove (moved to own repository)": https://gerrit.osmocom.org/c/osmo-sgsn/+/22591

Related issues

Related to osmo-gbproxy - Feature #5009: Tag first proper release after repository splitResolved02/04/2021

Associated revisions

Revision 29532c2a (diff)
Added by osmith about 1 month ago

=== Split osmo-gbproxy from osmo-sgsn ===

Adjust the build system, packaging etc. to split osmo-gbproxy into its
own git repository. Remove tests and configs that aren't related to
osmo-gbproxy.

Related: OS#4992

Revision 936dfd72 (diff)
Added by laforge about 1 month ago

Further clean-up in osmo-sgsn -> osmo-gbproxy migration

  • fix manuals builds, including vty reference generation
  • fix vty tests
  • remove manuals from osmo-sgsn
  • update .gitreview
  • update osmoappdesc.py

Related: OS#4992
Change-Id: I80439ab0d21a3fb33f38da42acbfe3fbb0941b91

Revision 383bacac (diff)
Added by osmith about 1 month ago

contrib/jenkins.sh: adjust to osmo-gbproxy split

Related: OS#4992
Change-Id: Ie82fc7a5a1166507460cf96ddbdf8ca77430ea64

Revision df0507e0 (diff)
Added by laforge about 1 month ago

Update README to cover osmo-gbproxy and not osmo-sgsn

While we're at it, also convert it to markdown.

Related: OS#4992
Change-Id: Ic7e86dfed985f98ae87af9adcde6f776c5a15044

Revision 882049d3 (diff)
Added by osmith about 1 month ago

debian: fix installing pdfs for -doc package

Don't comment out the pdf glob, it works as intended when building the
package on OBS. I had disabled it, because with dpkg-buildpackage,
override_dh_auto_configure from debian/ruls gets ignored, leading to
--enable-manuals missing in ./configure, and to the pdf file not being
present. But apparently, dpkg-buildpackage just always ignores this,
it's the same with other Osmocom repositories.

Related: OS#4992
Change-Id: I67c71af1406516e1262792b0d7566b3a9470e37f

Revision cd3e8e65 (diff)
Added by osmith about 1 month ago

contrib/osmo-gbproxy.spec.in: fix config paths

Make the spec file build (verified with own OBS namespace).

Related: OS#4992
Change-Id: I0b90d1e1a270963d5a053c95825c30193655e798

Revision ba06957c (diff)
Added by daniel about 1 month ago

Add osmo-gbproxy-* container for osmo-gbproxy

Uses the new repo split off of osmo-sgsn

Related: OS#4992
Change-Id: I1e7ede4d1da54e3bcb286213b34401bd9dcf7cc1

Revision 901ed14c (diff)
Added by osmith 27 days ago

gbproxy: remove (moved to own repository)

New repository:
https://git.osmocom.org/osmo-gbproxy/

Related: OS#4992
Change-Id: I37f7cebaf2a06bd93627a452f5df44edcfc0f87a

Revision a8fa5671 (diff)
Added by osmith 20 days ago

d/changelog: set epoch=1

Let apt know that the current 0.0.1 release of the split osmo-gbproxy
repository should be preferred over all packages from before the split.

Related: https://www.debian.org/doc/debian-policy/ch-controlfields.html#version
Related: OS#4992
Change-Id: I3e3749cd14bff3b38261ae048b928ea8c54dfcef

History

#1 Updated by osmith about 1 month ago

  • Checklist item run git filter-branch (move src/gbproxy/* to src/*, remove history of all includes but gb_proxy.h) added
  • Checklist item create repository in gerrit added
  • Checklist item push to repository on gerrit (version after git filter-branch, doesn't build yet; further changes are in osmith/wip) added
  • Checklist item adjust configure.ac, Makefile.am files to make it build again, add vty.h, debug.h in src/ added
  • Checklist item adjust debian packaging added
  • Checklist item adjust rpm spec file added
  • Checklist item verify that osmo-gbproxy builds for debian10 on obs, and tweak it until it does work added
  • Checklist item push fixes for build system and packaging to master added
  • Checklist item verify that OBS can build the rpm spec file added
  • Checklist item add osmo-gbproxy to git.osmocom.org (sync from gerrit) added
  • Checklist item remove osmo-gbproxy from osmo-sgsn.git (do this before building osmo-gbproxy deb in official nightly OBS, otherwise we'll have conflicts when installing both) added
  • Checklist item add osmo-gbproxy to osmo-ci.git master-builds / gerrit verification added
  • Checklist item enable osmo-gbproxy in osmo-ci.git OBS scripts for nightly added

#2 Updated by osmith about 1 month ago

  • Checklist item debian: fix building manuals added
  • Checklist item remove unrelated manuals added

Manuals are currently not getting built for the debian package.

For some reason, override_dh_auto_configure with its custom ./configure flags gets ignored (in debian/rules), leading to --enable-manuals not being used.

So I'll leave that out for the initial version. As workaround, I've commented *.pdf out in 'debian/osmo-gbproxy-doc.install'.

EDIT: this issue can be reproduced when building the package locally, as described here: https://osmocom.org/projects/cellular-infrastructure/wiki/Build_from_Source#Build-debian-packages

#3 Updated by osmith about 1 month ago

  • Checklist item fix VTY tests added
  • Checklist item verify that osmo-gbproxy builds for debian10 on obs, and tweak it until it does work set to Done
  • Checklist item push fixes for build system and packaging to master set to Done
  • Checklist item add osmo-gbproxy to git.osmocom.org (sync from gerrit) set to Done

#4 Updated by osmith about 1 month ago

  • Checklist item add osmo-gbproxy to osmo-ci.git master-builds / gerrit verification set to Done
  • Checklist item remove unrelated manuals set to Done
  • Checklist item fix VTY tests set to Done

#5 Updated by osmith about 1 month ago

  • % Done changed from 60 to 70

#6 Updated by osmith about 1 month ago

  • Checklist item verify that OBS can build the rpm spec file set to Done
  • Checklist item remove osmo-gbproxy from osmo-sgsn.git (do this before building osmo-gbproxy deb in official nightly OBS, otherwise we'll have conflicts when installing both) set to Done
  • Checklist item enable osmo-gbproxy in osmo-ci.git OBS scripts for nightly set to Done
  • Checklist item debian: fix building manuals set to Done

#7 Updated by osmith about 1 month ago

  • % Done changed from 70 to 90

#8 Updated by daniel about 1 month ago

(probably wrong) Patch for docker-playground:

https://gerrit.osmocom.org/c/docker-playground/+/22636

#9 Updated by osmith about 1 month ago

  • Checklist item adjust docker containers for ttcn-3 tests (thanks, Daniel) added
  • Checklist item roll out: merge "OBS nightly: add osmo-gbproxy: https://gerrit.osmocom.org/c/osmo-ci/+/22603 added
  • Checklist item roll out: merge "Add osmo-gbproxy-* container for osmo-gbproxy": https://gerrit.osmocom.org/c/docker-playground/+/22636 added
  • Checklist item roll out: wait until OBS nightly has built gbproxy packages added
  • Checklist item roll out: successful ttcn3 test run at jenkins with split package added
  • Checklist item roll out: merge "gbproxy: remove (moved to own repository)": https://gerrit.osmocom.org/c/osmo-sgsn/+/22591 added

Added checklist items for roll out.

Heads up: the repo-install-test might run and fail before the last patch is merged. The repo install test tries to install all packages from the repo at the same time, and will get and unexpected conflict while trying to install osmo-sgsn and osmo-gbproxy at the same time.

#10 Updated by osmith about 1 month ago

daniel: Now waiting on a new iteration of the docker-playground patch. I can take it over if you like.

Follow-up for tagging a version after a new libosmocore release: #5009

#11 Updated by osmith about 1 month ago

  • Related to Feature #5009: Tag first proper release after repository split added

#12 Updated by daniel about 1 month ago

I'm looking at it atm

#13 Updated by osmith 27 days ago

  • Checklist item roll out: merge "Add osmo-gbproxy-* container for osmo-gbproxy": https://gerrit.osmocom.org/c/docker-playground/+/22636 set to Done
  • Checklist item roll out: wait until OBS nightly has built gbproxy packages set to Done
  • Checklist item roll out: successful ttcn3 test run at jenkins with split package set to Done
  • Checklist item roll out: merge "gbproxy: remove (moved to own repository)": https://gerrit.osmocom.org/c/osmo-sgsn/+/22591 set to Done
  • Status changed from In Progress to Resolved
  • % Done changed from 90 to 100

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)