Project

General

Profile

Bug #5075

Possibly misleading component value labels on Silkscreen

Added by cibomahto about 1 month ago. Updated 25 days ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
03/15/2021
Due date:
% Done:

100%


Description

Some of the components have their value labeled next to them in the silkscreen. Unfortunately, this was done by placing loose text objects on the PCB, that aren't linked in any way to the component values in the schematic. Should they be removed? I wouldn't touch them, except that I have to re-arrange the silkscreen labels to increase the text size per https://osmocom.org/issues/5068

extraneous component values.png View extraneous component values.png 354 KB cibomahto, 03/15/2021 02:48 PM
unassociated text strings - bottom.png View unassociated text strings - bottom.png 417 KB cibomahto, 03/17/2021 01:54 PM
unassociated text strings - top.png View unassociated text strings - top.png 572 KB cibomahto, 03/17/2021 01:54 PM
after.png View after.png 538 KB cibomahto, 03/22/2021 12:29 PM
THT-deco-font.png View THT-deco-font.png 55.3 KB mschramm, 03/22/2021 12:52 PM
Screenshot 2021-03-22 144444.png View Screenshot 2021-03-22 144444.png 257 KB cibomahto, 03/22/2021 01:44 PM
P3-deco-silk_bott.png View P3-deco-silk_bott.png 80 KB mschramm, 03/27/2021 09:51 PM
before.png View before.png 122 KB cibomahto, 03/28/2021 02:52 PM
after.png View after.png 160 KB cibomahto, 03/28/2021 02:52 PM
4543
4568
4569
4577
4578
4579
4605
4609
4610

History

#1 Updated by cibomahto about 1 month ago

Note: The above screenshot only has a few of the labels highlighted, in fact all of the component values on the silkscreen are not with their schematic values.

#2 Updated by mschramm about 1 month ago

Yes, this is a mess, - as there also 'real' errors like https://github.com/openvizsla/ov_ftdi/issues/42 . I'll discuss this with laforge , let's postpone this ticket towards the end and at least not before #5068.

#3 Updated by laforge about 1 month ago

  • Status changed from New to Feedback
  • Assignee changed from laforge to mschramm
I would in general argue in favor of
  • removing all values (like 12Mhz, 120 Ohms) from the silk screen.
  • keeping only the designators (R12, C55, ...) whihc hopefully are automatically generated

This reflects what we do in the "native, non-inherited" osmocom designs, too.

Furthermore:
  • [martin?] checking + [cibomahto] fixing all the labels next to pins/gpios, where we also know of at least one error (1V2 vs 5V)

#4 Updated by mschramm about 1 month ago

  • Status changed from Feedback to In Progress
  • Assignee changed from mschramm to cibomahto

laforge wrote:

  • removing all values (like 12Mhz, 120 Ohms) from the silk screen.
  • keeping only the designators (R12, C55, ...) whihc hopefully are automatically generated

affirmative.

Me still searching for further errors on the pin header like the one known (see above).

#5 Updated by cibomahto about 1 month ago

4568
4569

To aid in your search, here are snaps of all the text labels that are on the board, which are not linked to a component.

#6 Updated by cibomahto about 1 month ago

4577

Addressed here: https://github.com/openvizsla/ov_ftdi/pull/46/commits/c375a9521479726700d115124904ca306fbb89ec

  • Remove component values from silkscreen
  • Remove pin # labels and tick marks from silkscreen
  • Verify that component designators are located next to the correct
    parts
  • Fix 1v2 and 5v labels on P4

mschramm if you find any more errors, please let me know.

#7 Updated by mschramm about 1 month ago

4578

Thanks, looks good so far!
But somewhat even before the pin numbers on the THT headers went to ... erm, Arial ?! ;) Let them become calibri again (or a simple vector font).

#8 Updated by cibomahto about 1 month ago

It looks like they were previously vector font, and got switched to the default truetype font (Arial). Updated here (and corrected the orientation of the ones on P3):

https://github.com/openvizsla/ov_ftdi/pull/46/commits/c6dcce2190937fdf3b5a1fd5100a4f517a3d7eca

These pin numbers do happen to be attached to the header footprints

#10 Updated by mschramm 26 days ago

4605

cibomahto wrote:

mschramm if you find any more errors, please let me know.

All THT header checked, only one error remaining:

Pin 19 of P3 is designated on the bottom side as TDI, which is wrong, it rather is connected to TDO. Please change this label on the bott side to TDO (lower case: "tdo").

#12 Updated by mschramm 25 days ago

  • Status changed from In Progress to Resolved
  • % Done changed from 90 to 100

solved, thanks

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)