Bug #5173: Makefile.am uses HAVE_PCAP, HAVE_SQLITE3 to conditionally build some binaries - OsmoBSC - Open Source Mobile Communications

Actions

Copy link

Bug #5173

closed

Makefile.am uses HAVE_PCAP, HAVE_SQLITE3 to conditionally build some binaries

Added by osmith almost 3 years ago. Updated 9 months ago.

Status:

Resolved

Priority:

Low

Assignee:

osmith

Category:

Target version:

Start date:

06/07/2021

Due date:

% Done:

100%

Spec Reference:

Description

In https://gerrit.osmocom.org/c/osmo-bsc/+/24421, the jenkins verification passed, but the package fails to build in OBS:

meas_vis.c:196:16: error: 'struct gsm_meas_rep' has no member named 'bs_power'; did you mean 'bs_power_db'?

This is because Makefile.am builds meas_vis only if LIBCDK is installed, and apparently we don't have it installed on jenkins:

if HAVE_LIBCDK
bin_PROGRAMS += \
    meas_vis \
    $(NULL)
endif

To avoid this in the future, the "if HAVE_"s in Makefile.am need to be replaced with explicitly selecting/unselecting additional programs with ./configure flags. The default should not depend on what libraries are installed. (There was a mail thread or issue about this already, but I can't find it right now.)