Project

General

Profile

Bug #3389

osmo-sgsn: runtime error: null pointer in memcpy

Added by pespin 4 months ago. Updated 4 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
07/09/2018
Due date:
% Done:

100%

Spec Reference:

Description

While running osmo-sgsn master today:

20180709131409837 DLINP <001d> /home/pespin/dev/sysmocom/git/libosmo-abis/src/input/ipa.c:56 127.0.0.1:4222 message received
20180709131409837 DGPRS <000e> /home/pespin/dev/sysmocom/git/osmo-sgsn/src/gprs/gprs_subscriber.c:715 SUBSCR(901700000015254) Received GSUP message OSMO_GSUP_MSGT_INSERT_DATA_REQUEST
20180709131409837 DGPRS <000e> /home/pespin/dev/sysmocom/git/osmo-sgsn/src/gprs/gprs_subscriber.c:364 SUBSCR(901700000015254) Will set PDP info, context id = 1, APN = 01 2a
/home/pespin/dev/sysmocom/git/osmo-sgsn/src/gprs/gprs_subscriber.c:377:3: runtime error: null pointer passed as argument 2, which is declared to never be null
20180709131409838 DGPRS <000e> /home/pespin/dev/sysmocom/git/osmo-sgsn/src/gprs/gprs_subscriber.c:817 SUBSCR(901700000015254) Updating subscriber data
20180709131409838 DMM <0002> /home/pespin/dev/sysmocom/git/osmo-sgsn/src/gprs/gprs_sgsn.c:728 MM(901700000015254/c7e21a7f) Subscriber data update

Affected line is in gprs_subscr_gsup_insert_data:

        memcpy(pdp_data->qos_subscribed, pdp_info->qos_enc, pdp_info->qos_enc_len);

History

#1 Updated by pespin 4 months ago

  • Status changed from New to In Progress
  • Assignee set to pespin

Found another two:

/home/pespin/dev/sysmocom/git/osmo-sgsn/src/gprs/sgsn_libgtp.c:204:2: runtime error: null pointer passed as argument 2, which is declared to never be null
/home/pespin/dev/sysmocom/git/osmo-sgsn/src/gprs/sgsn_libgtp.c:211:2: runtime error: null pointer passed as argument 2, which is declared to never be null

#2 Updated by pespin 4 months ago

  • Status changed from In Progress to Feedback
  • % Done changed from 0 to 90

#3 Updated by pespin 4 months ago

  • Status changed from Feedback to Resolved
  • % Done changed from 90 to 100

Merged, closing.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)