Project

General

Profile

Actions

Feature #4992

closed

Split osmo-gbproxy from osmo-sgsn into own git repository

Added by osmith about 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
Start date:
01/29/2021
Due date:
% Done:

100%

Spec Reference:

Description

As discussed, we want to split osmo-gbproxy into its own git repository.

I'll append a checklist to this issue shortly.


Checklist

  • run git filter-branch (move src/gbproxy/* to src/*, remove history of all includes but gb_proxy.h)
  • create repository in gerrit
  • push to repository on gerrit (version after git filter-branch, doesn't build yet; further changes are in osmith/wip)
  • adjust configure.ac, Makefile.am files to make it build again, add vty.h, debug.h in src/
  • adjust debian packaging
  • add osmo-gbproxy to git.osmocom.org (sync from gerrit)
  • adjust rpm spec file
  • verify that osmo-gbproxy builds for debian10 on obs, and tweak it until it does work
  • push fixes for build system and packaging to master
  • verify that OBS can build the rpm spec file
  • remove osmo-gbproxy from osmo-sgsn.git (do this before building osmo-gbproxy deb in official nightly OBS, otherwise we'll have conflicts when installing both)
  • add osmo-gbproxy to osmo-ci.git master-builds / gerrit verification
  • enable osmo-gbproxy in osmo-ci.git OBS scripts for nightly
  • debian: fix building manuals
  • remove unrelated manuals
  • fix VTY tests
  • adjust docker containers for ttcn-3 tests (thanks, Daniel)
  • roll out: merge "OBS nightly: add osmo-gbproxy: https://gerrit.osmocom.org/c/osmo-ci/+/22603
  • roll out: merge "Add osmo-gbproxy-* container for osmo-gbproxy": https://gerrit.osmocom.org/c/docker-playground/+/22636
  • roll out: wait until OBS nightly has built gbproxy packages
  • roll out: successful ttcn3 test run at jenkins with split package
  • roll out: merge "gbproxy: remove (moved to own repository)": https://gerrit.osmocom.org/c/osmo-sgsn/+/22591

Related issues

Related to osmo-gbproxy - Feature #5009: Tag first proper release after repository splitResolvedosmith02/04/2021

Actions
Actions #1

Updated by osmith about 3 years ago

  • Checklist item run git filter-branch (move src/gbproxy/* to src/*, remove history of all includes but gb_proxy.h) added
  • Checklist item create repository in gerrit added
  • Checklist item push to repository on gerrit (version after git filter-branch, doesn't build yet; further changes are in osmith/wip) added
  • Checklist item adjust configure.ac, Makefile.am files to make it build again, add vty.h, debug.h in src/ added
  • Checklist item adjust debian packaging added
  • Checklist item adjust rpm spec file added
  • Checklist item verify that osmo-gbproxy builds for debian10 on obs, and tweak it until it does work added
  • Checklist item push fixes for build system and packaging to master added
  • Checklist item verify that OBS can build the rpm spec file added
  • Checklist item add osmo-gbproxy to git.osmocom.org (sync from gerrit) added
  • Checklist item remove osmo-gbproxy from osmo-sgsn.git (do this before building osmo-gbproxy deb in official nightly OBS, otherwise we'll have conflicts when installing both) added
  • Checklist item add osmo-gbproxy to osmo-ci.git master-builds / gerrit verification added
  • Checklist item enable osmo-gbproxy in osmo-ci.git OBS scripts for nightly added
Actions #2

Updated by osmith about 3 years ago

  • Checklist item debian: fix building manuals added
  • Checklist item remove unrelated manuals added

Manuals are currently not getting built for the debian package.

For some reason, override_dh_auto_configure with its custom ./configure flags gets ignored (in debian/rules), leading to --enable-manuals not being used.

So I'll leave that out for the initial version. As workaround, I've commented *.pdf out in 'debian/osmo-gbproxy-doc.install'.

EDIT: this issue can be reproduced when building the package locally, as described here: https://osmocom.org/projects/cellular-infrastructure/wiki/Build_from_Source#Build-debian-packages

Actions #3

Updated by osmith about 3 years ago

  • Checklist item fix VTY tests added
  • Checklist item verify that osmo-gbproxy builds for debian10 on obs, and tweak it until it does work set to Done
  • Checklist item push fixes for build system and packaging to master set to Done
  • Checklist item add osmo-gbproxy to git.osmocom.org (sync from gerrit) set to Done
Actions #4

Updated by osmith about 3 years ago

  • Checklist item add osmo-gbproxy to osmo-ci.git master-builds / gerrit verification set to Done
  • Checklist item remove unrelated manuals set to Done
  • Checklist item fix VTY tests set to Done
Actions #5

Updated by osmith about 3 years ago

  • % Done changed from 60 to 70
Actions #6

Updated by osmith about 3 years ago

  • Checklist item verify that OBS can build the rpm spec file set to Done
  • Checklist item remove osmo-gbproxy from osmo-sgsn.git (do this before building osmo-gbproxy deb in official nightly OBS, otherwise we'll have conflicts when installing both) set to Done
  • Checklist item enable osmo-gbproxy in osmo-ci.git OBS scripts for nightly set to Done
  • Checklist item debian: fix building manuals set to Done
Actions #7

Updated by osmith about 3 years ago

  • % Done changed from 70 to 90
Actions #8

Updated by daniel about 3 years ago

(probably wrong) Patch for docker-playground:

https://gerrit.osmocom.org/c/docker-playground/+/22636

Actions #9

Updated by osmith about 3 years ago

  • Checklist item adjust docker containers for ttcn-3 tests (thanks, Daniel) added
  • Checklist item roll out: merge "OBS nightly: add osmo-gbproxy: https://gerrit.osmocom.org/c/osmo-ci/+/22603 added
  • Checklist item roll out: merge "Add osmo-gbproxy-* container for osmo-gbproxy": https://gerrit.osmocom.org/c/docker-playground/+/22636 added
  • Checklist item roll out: wait until OBS nightly has built gbproxy packages added
  • Checklist item roll out: successful ttcn3 test run at jenkins with split package added
  • Checklist item roll out: merge "gbproxy: remove (moved to own repository)": https://gerrit.osmocom.org/c/osmo-sgsn/+/22591 added

Added checklist items for roll out.

Heads up: the repo-install-test might run and fail before the last patch is merged. The repo install test tries to install all packages from the repo at the same time, and will get and unexpected conflict while trying to install osmo-sgsn and osmo-gbproxy at the same time.

Actions #10

Updated by osmith about 3 years ago

daniel: Now waiting on a new iteration of the docker-playground patch. I can take it over if you like.

Follow-up for tagging a version after a new libosmocore release: #5009

Actions #11

Updated by osmith about 3 years ago

  • Related to Feature #5009: Tag first proper release after repository split added
Actions #12

Updated by daniel about 3 years ago

I'm looking at it atm

Actions #13

Updated by osmith about 3 years ago

  • Checklist item roll out: merge "Add osmo-gbproxy-* container for osmo-gbproxy": https://gerrit.osmocom.org/c/docker-playground/+/22636 set to Done
  • Checklist item roll out: wait until OBS nightly has built gbproxy packages set to Done
  • Checklist item roll out: successful ttcn3 test run at jenkins with split package set to Done
  • Checklist item roll out: merge "gbproxy: remove (moved to own repository)": https://gerrit.osmocom.org/c/osmo-sgsn/+/22591 set to Done
  • Status changed from In Progress to Resolved
  • % Done changed from 90 to 100
Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)