Bug #5306: osmo-pcu: deprecate -i cmdline param and add vty cmd 'gsmtap-remote-host' as in osmo-bts - OsmoPCU - Open Source Mobile Communications

Actions

Copy link

Bug #5306

closed

osmo-pcu: deprecate -i cmdline param and add vty cmd 'gsmtap-remote-host' as in osmo-bts

Added by pespin over 2 years ago. Updated over 2 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

pespin

Target version:

Start date:

11/12/2021

Due date:

% Done:

100%

Spec Reference:

Description

From osmo-bts:

doc/manuals/chapters/configuration.adoc
119: gsmtap-remote-host 127.0.0.1 <1>

tests/osmo-bts.vty
252:  gsmtap-remote-host [HOSTNAME]
253:  no gsmtap-remote-host
275:  gsmtap-remote-host  Enable GSMTAP Um logging (see also 'gsmtap-sapi')

src/common/main.c
196:                                "parameter 'gsmtap-remote-host %s' instead.\n", gsmtap_ip);
366:                             "'gsmtap-remote-host %s' from the config file\n",

src/common/vty.c
324:            vty_out(vty, " gsmtap-remote-host %s%s",
2081:      "gsmtap-remote-host [HOSTNAME]",
2098:      "no gsmtap-remote-host",

Also in osmo-bts main.c:

        case 'i':
            gsmtap_ip = optarg;
            fprintf(stderr, "Command line argument '-i' is deprecated, use VTY " 
                "parameter 'gsmtap-remote-host %s' instead.\n", gsmtap_ip);
            break;