Feature #5906
closedSCCP CR has a 130 byte limit on data payload, now enforced in libosmo-sigtran. Remove 'sccp cr max-payload-len' cfg option from osmo-hnbgw
100%
Description
First, we implemented an SCCP CR data size limit in osmo-hnbgw by means of a new cfg option 'sccp cr max-payload-len'.
When it became clear that there is a specified limit of 130 bytes that applies to all SCCP CR in general, we implemented this in libosmo-sigtran, proper.
Since this is now released in libosmo-sigtran v1.7.0, we should deprecate the 'sccp cr max-payload-len' cfg and remove all relevant code from osmo-hnbgw.
https://gitea.osmocom.org/cellular-infrastructure/osmo-hnbgw/commit/2c91bd66a1dc4740282c9f8221f80da0d688a293
https://gitea.osmocom.org/osmocom/libosmo-sccp/commit/e5d615efdcffa9b248c555d1db5ce596649ef28d
Related issues
Updated by neels about 1 year ago
- Related to Bug #5579: Respect size limit of 130 data bytes in SCCP CR added
Updated by neels about 1 year ago
I have this patch ready:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/31326
but running the HNBGW_Tests.ttcn with this applied fails the two SCCP CR data limit tests:
pass->FAIL HNBGW_Tests.TC_ranap_cs_initial_ue_empty_cr
pass->FAIL HNBGW_Tests.TC_ranap_ps_initial_ue_empty_cr
I am still figuring out why.
Updated by neels about 1 year ago
The reason for failing tests:
The payload being tested is only 65 bytes in size, hence libosmo-sigtran does not trigger the condition to send an empty CR.
The tests tell osmo-hnbgw to enforce a SCCP CR payload limit of 0 instead, so they expect the CR data to always be sent separately.
I need to make the tested payload larger for the separation to trigger.
Updated by neels about 1 year ago
- Status changed from New to Resolved
- % Done changed from 0 to 100
patch merged
