Actions
Bug #6486
closedimage_suffix_is_master gets confused with -asan builds
Start date:
06/11/2024
Due date:
% Done:
100%
Spec Reference:
Description
I reproduced the failures from ttcn3-stp-test-asan (https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-stp-test-asan/) by running the jenkins.sh like jenkins does:
IMAGE_SUFFIX=asan OSMOCOM_REPO_VERSION="asan" ./jenkins.sh
As seen in the logs and in the pcap the tester tries to connect to osmo-stp via TCP, but the connection is refused. The jenkins.sh contains
# XXX: M3UA-over-TCP is not supported by osmo-stp <= 1.8.1 if image_suffix_is_master; then osmo-config-merge ./osmo-stp.cfg \ ./osmo-stp-tcp.confmerge \ > "$VOL_BASE_DIR/stp/osmo-stp.cfg" fi
which isn't run for -asan.
If I add a test case to image_suffix_is_master for asan the tests pass, but I wonder if we could solve it in a different way that is not so brittle?
Updated by osmith 18 days ago
- Status changed from New to In Progress
- % Done changed from 0 to 90
Thanks for figuring this out!
I think your patch does the right thing, see review comments there:
https://gerrit.osmocom.org/c/docker-playground/+/37192
Actions